-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix init-windows template to automatically detect existing codegen spec files #15096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: anupriya13 <[email protected]>
|
@copilot don't add a comment for developer to fix, we need to get the correct file name from |
…dcoded names Co-authored-by: anupriya13 <[email protected]>
I've updated the solution to automatically detect existing codegen spec files instead of using TODO comments. The template now:
This eliminates the need for manual developer intervention while handling both scenarios correctly. (commit b02696d) |
sundaramramaswamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…opers Co-authored-by: sundaramramaswamy <[email protected]>
sundaramramaswamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@copilot run yarn change prerelease and yarn lint:fix |
Co-authored-by: anupriya13 <[email protected]>
Completed both tasks:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
packages/@react-native-windows/tester/src/js/examples/FlatList/FlatList-multiColumn.windows.js
Show resolved
Hide resolved
Co-authored-by: anupriya13 <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@copilot fix pipeline issues for fabric new windows\testcli\testcli.cpp |
…ents Co-authored-by: anupriya13 <[email protected]>
Fixed the Mustache template parsing error. The issue was that the explanatory comments contained example Mustache syntax tags ({{#variable}}, {{^variable}}, {{/variable}}) which the template parser was trying to process as actual template code, causing the "Unclosed section 'variable' at 1794" error. Removed the example syntax from the comments while keeping the explanations. (commit 4f5620f) |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…ec files (#15096) * Initial plan * Fix init-windows template to use conditional codegen includes Co-authored-by: anupriya13 <[email protected]> * Automatically detect existing codegen spec files instead of using hardcoded names Co-authored-by: anupriya13 <[email protected]> * Add explanatory comments about Mustache template syntax for C++ developers Co-authored-by: sundaramramaswamy <[email protected]> * Change files * Run yarn change prerelease and yarn lint:fix Co-authored-by: anupriya13 <[email protected]> * Revert unrelated changes to FlatList-multiColumn.windows.js Co-authored-by: anupriya13 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: anupriya13 <[email protected]> Co-authored-by: sundaramramaswamy <[email protected]> Co-authored-by: Sundaram Ramaswamy <[email protected]>
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Microsoft Reviewers: Open in CodeFlow