chore(android): remove unused code #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelset
approved these changes
Aug 17, 2022
tido64
force-pushed
the
tido/fix-codegen
branch
from
ae48b95 to
2023231
Compare
tido64
force-pushed
the
tido/fix-codegen
branch
from
2023231 to
b8d55fb
Compare
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 18, 2022
Summary: With react-native 0.70-rc.3 and new arch, codegen may fail if it encounters `.d.ts` files because specs may appear to be unused. ## Changelog [General] [Fixed] - Codegen should ignore `.d.ts` files Pull Request resolved: #34439 Test Plan: See repro in microsoft/react-native-test-app#1052. The build will fail without manually patching this in. If you prefer to use your own test app, try adding [react-native-safe-area-context](https://github.com/th3rdwave/react-native-safe-area-context) as a dependency. Reviewed By: cipolleschi Differential Revision: D38826388 Pulled By: cortinico fbshipit-source-id: eb7c9be2d49286bae86b2428862fbf20f6f32ca5
tido64
force-pushed
the
tido/fix-codegen
branch
from
b8d55fb to
7ff2483
Compare
tido64
force-pushed
the
tido/fix-codegen
branch
from
7ff2483 to
f249a35
Compare
tido64
changed the title
kelset
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 22, 2022
Summary: With react-native 0.70-rc.3 and new arch, codegen may fail if it encounters `.d.ts` files because specs may appear to be unused. ## Changelog [General] [Fixed] - Codegen should ignore `.d.ts` files Pull Request resolved: #34439 Test Plan: See repro in microsoft/react-native-test-app#1052. The build will fail without manually patching this in. If you prefer to use your own test app, try adding [react-native-safe-area-context](https://github.com/th3rdwave/react-native-safe-area-context) as a dependency. Reviewed By: cipolleschi Differential Revision: D38826388 Pulled By: cortinico fbshipit-source-id: eb7c9be2d49286bae86b2428862fbf20f6f32ca5
kelset
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 24, 2022
Summary: With react-native 0.70-rc.3 and new arch, codegen may fail if it encounters `.d.ts` files because specs may appear to be unused. ## Changelog [General] [Fixed] - Codegen should ignore `.d.ts` files Pull Request resolved: #34439 Test Plan: See repro in microsoft/react-native-test-app#1052. The build will fail without manually patching this in. If you prefer to use your own test app, try adding [react-native-safe-area-context](https://github.com/th3rdwave/react-native-safe-area-context) as a dependency. Reviewed By: cipolleschi Differential Revision: D38826388 Pulled By: cortinico fbshipit-source-id: eb7c9be2d49286bae86b2428862fbf20f6f32ca5
Titozzz
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 10, 2022
Summary: With react-native 0.70-rc.3 and new arch, codegen may fail if it encounters `.d.ts` files because specs may appear to be unused. ## Changelog [General] [Fixed] - Codegen should ignore `.d.ts` files Pull Request resolved: #34439 Test Plan: See repro in microsoft/react-native-test-app#1052. The build will fail without manually patching this in. If you prefer to use your own test app, try adding [react-native-safe-area-context](https://github.com/th3rdwave/react-native-safe-area-context) as a dependency. Reviewed By: cipolleschi Differential Revision: D38826388 Pulled By: cortinico fbshipit-source-id: eb7c9be2d49286bae86b2428862fbf20f6f32ca5
diegolmello
pushed a commit
to RocketChat/react-native
that referenced
this pull request
Feb 2, 2023
Summary: With react-native 0.70-rc.3 and new arch, codegen may fail if it encounters `.d.ts` files because specs may appear to be unused. ## Changelog [General] [Fixed] - Codegen should ignore `.d.ts` files Pull Request resolved: facebook#34439 Test Plan: See repro in microsoft/react-native-test-app#1052. The build will fail without manually patching this in. If you prefer to use your own test app, try adding [react-native-safe-area-context](https://github.com/th3rdwave/react-native-safe-area-context) as a dependency. Reviewed By: cipolleschi Differential Revision: D38826388 Pulled By: cortinico fbshipit-source-id: eb7c9be2d49286bae86b2428862fbf20f6f32ca5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove code that are no longer used.
Platforms affected
Test plan
n/a