Skip to content

fix(only-changed): show nice error message about shallow clones #32189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2024
Merged

fix(only-changed): show nice error message about shallow clones #32189

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36baa26
fix(only-changed): show nice error message about shallow clones
Skn0tt Aug 16, 2024
dd0eddd
Update packages/playwright/src/runner/vcs.ts
Skn0tt Aug 16, 2024
91b478e
simplify error message to not point user into wrong direction
Skn0tt Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/playwright/src/runner/vcs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,18 @@ export async function detectChangedTestFiles(baseCommit: string, configDir: stri
).split('\n').filter(Boolean);
} catch (_error) {
const error = _error as childProcess.SpawnSyncReturns<string>;

const unknownRevision = error.output.some(line => line?.includes('unknown revision'));
if (unknownRevision) {
const isShallowClone = childProcess.execSync('git rev-parse --is-shallow-repository', { encoding: 'utf-8', stdio: 'pipe' }).trim() === 'true';
if (isShallowClone) {
throw new Error([
`The repository is a shallow clone and does not have '${baseCommit}' available locally.`,
`Note that GitHub Actions checkout is shallow by default: https://github.com/actions/checkout`
].join('\n'));
}
}

throw new Error([
`Cannot detect changed files for --only-changed mode:`,
`git ${command}`,
Expand Down