Skip to content

Conversation

@mapodaca-nv
Copy link
Contributor

@mapodaca-nv mapodaca-nv commented Jul 14, 2025

Proposes a base alignment attribute for ByteAddressBuffer declarations and new templated Load/Store functions that include a relative alignment argument.

Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial changes in the comments. It'd be good to get a sponsor agreed upon before completing the PR, but I think otherwise it looks pretty ready to get merged.

@damyanp damyanp self-assigned this Oct 21, 2025
Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metadata needs to be updated and a sponsor found before we can assign a proposal number.

Maybe @amarpMSFT or @tex3d would be up for sponsoring?

@damyanp damyanp removed their assignment Oct 22, 2025
Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to merge to me.

At this point we should be prioritizing getting the proposal merged - so it has a proposal number assigned etc.

Additional work - feedback, or fleshing out parts of the spec, can be tracked by github issues.

(This PR is working to try and clarify the process: #689)

Copy link
Collaborator

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've filed a number of follow-up issues and resolved comments in order to allow for this document to be assigned a number and merged.

In doing so, I also realized we might be better off splitting the AlignedLoad/AlignedStore HLSL intrinsics into a separate proposal. See #720.

For the remaining comments, please make corresponding changes or file more issues for future follow-up (like ones I've filed on other comments I resolved) and resolve them.

Before merging, you'll need to assign the next number to this proposal and rename the file. I've assumed 0050 in all my issues and links, so it would be great if we can use that number.

Then we can re-approve that version as necessary and merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants