-
Notifications
You must be signed in to change notification settings - Fork 51
ByteAddressBuffer Alignment proposal #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ByteAddressBuffer Alignment proposal #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editorial changes in the comments. It'd be good to get a sponsor agreed upon before completing the PR, but I think otherwise it looks pretty ready to get merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metadata needs to be updated and a sponsor found before we can assign a proposal number.
Maybe @amarpMSFT or @tex3d would be up for sponsoring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ready to merge to me.
At this point we should be prioritizing getting the proposal merged - so it has a proposal number assigned etc.
Additional work - feedback, or fleshing out parts of the spec, can be tracked by github issues.
(This PR is working to try and clarify the process: #689)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've filed a number of follow-up issues and resolved comments in order to allow for this document to be assigned a number and merged.
In doing so, I also realized we might be better off splitting the AlignedLoad/AlignedStore HLSL intrinsics into a separate proposal. See #720.
For the remaining comments, please make corresponding changes or file more issues for future follow-up (like ones I've filed on other comments I resolved) and resolve them.
Before merging, you'll need to assign the next number to this proposal and rename the file. I've assumed 0050 in all my issues and links, so it would be great if we can use that number.
Then we can re-approve that version as necessary and merge the PR.
Proposes a base alignment attribute for ByteAddressBuffer declarations and new templated Load/Store functions that include a relative alignment argument.