Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Conversation

@edwardskrod
Copy link
Member

@edwardskrod edwardskrod commented Mar 11, 2020

  • Updated the PlatformTarget to simplify the .csproj.
  • Updated the trigger

@AArnott
Copy link
Member

AArnott commented Mar 11, 2020

This failure appears to be because the Action ran on push of your source branch (and your branch doesn't include the fix recently pushed to master).

Should you adjust your github workflow to trigger on PR, and keep the push trigger reserved to just the master branch? That way, the action would run on the merged result and it would have passed on this PR, even with the stale source branch.

@edwardskrod
Copy link
Member Author

This failure appears to be because the Action ran on push of your source branch (and your branch doesn't include the fix recently pushed to master).

Should you adjust your github workflow to trigger on PR, and keep the push trigger reserved to just the master branch? That way, the action would run on the merged result and it would have passed on this PR, even with the stale source branch.

That's a good idea. Thanks :)

@LanceMcCarthy
Copy link
Collaborator

That's how I've setup mine, and it's kept the noise down significantly https://github.com/LanceMcCarthy/MediaFileManager/blob/2559153c481d33c2fee584fce508913646878dc6/.github/workflows/ci.yml#L9-L15

@edwardskrod
Copy link
Member Author

@edwardskrod edwardskrod changed the title Updated the PlatformTarget. Update the PlatformTarget and CI trigger. Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants