Skip to content

remote-https: do not call fetch-pack if using gvfs helper #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2020
Merged

remote-https: do not call fetch-pack if using gvfs helper #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions remote-curl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,9 @@ static int fetch_git(struct discovery *heads,
struct argv_array args = ARGV_ARRAY_INIT;
struct strbuf rpc_result = STRBUF_INIT;

if (core_use_gvfs_helper)
Copy link

@jeffhostetler jeffhostetler Feb 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned this will effectively break remote-curl aka remote-https any time that gvfs-helper is configured (and without regard for whether it is in use by the current process ancestry).

Copy link
Author

@derrickstolee derrickstolee Feb 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, when using gvfs-helper we should avoid fetch-pack at all times. We never want to ask for a pack in the traditional way. Am I wrong?

The only thing I can think of is if we are fetching a submodule, but we do not support that case right now.

return 0;

argv_array_pushl(&args, "fetch-pack", "--stateless-rpc",
"--stdin", "--lock-pack", NULL);
if (options.followtags)
Expand Down