Winget does not install Visual Studio Integration / Visual Studio integration linked to autoupdate

[tyrielv]

The custom installer for microsoft/git includes Visual Studio integration, but it includes it as part of the AutoUpdate component.

The Winget manifest does not include the autoupdate component, so VS integration is not installed when using winget.

I don't know where the custom components list for winget is defined - it was first added in 2.47.0.0.3 by "SpecterShell", a third party. I suspect that the automated winget release just updates the previous manifest instead of declaring it explicitly.

Excluding autoupdate may have been intentional - some winget users may prefer to manually control updates - but if so, the VS integration should probably be moved to a different component.

Personally I would prefer if autoupdate were added to the components list.

[dscho]

The custom installer for microsoft/git includes Visual Studio integration, but it includes it as part of the AutoUpdate component.

Ah, that is correct. I just ran the sed command locally and this is the resulting diff:

diff --git a/installer/install.iss b/installer/install.iss
index fe1cb177f..62a104be9 100644
--- a/installer/install.iss
+++ b/installer/install.iss
@@ -3580,10 +3580,11 @@ begin
     }
 
     if IsComponentInstalled('autoupdate') then begin
         WizardForm.StatusLabel.Caption:='Set up daily up to date check';
         InstallAutoUpdater();
+              CustomPostInstall();
     end;
 
     {
         Run post-install scripts to set up system environment
     }
@@ -3919,10 +3920,11 @@ begin
         Remove the scheduled task to try to auto-update Git for Windows
     }
 
     if IsComponentInstalled('autoupdate') then
         UninstallAutoUpdater();
+              CustomPostUninstall();
 
     {
         Modify the environment
 
         This must happen no later than usUninstall to make

Obviously the latter is as intended, while the former is not. The CustomPostUninstall() is outside the conditional block, and so should CustomPostInstall()` be.

Will fix, probably by anchoring the edits to the if IsComponentInstalled('autoupdate') line and inserting the respective line before rather than after the anchor.

[dscho]

Personally I would prefer if autoupdate were added to the components list.

I do not think that this is a good idea when installing via winget, as the auto-updater wants to update Git via the installer, side-stepping winget completely.

[dscho]

Will fix, probably by anchoring the edits to the if IsComponentInstalled('autoupdate') line and inserting the respective line before rather than after the anchor.

→ #740