Fix SET KEEPTTL return string #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-montrose
pushed a commit
that referenced
this pull request
Feb 28, 2025
* SETKEEPTTL (no other flags) should always return ok. It doesn't care about NX or XX * Simplify GETSET --------- Co-authored-by: prvyk <[email protected]> Co-authored-by: Tal Zaccai <[email protected]>
kevin-montrose
added a commit
that referenced
this pull request
Mar 7, 2025
…a scripts (#1050) * implement redis.pcall * implement redis.sha1hex * half implement redis.log ; needs a config option, probably * add a custom error for redis.set_repl; that just cannot work in Garnet * add errors for redis.debug and redis.breakpoint * implementation of redis.acl_check_cmd * sort of implement setresp * implement redis.REDIS_VERSION and redis.REDIS_VERSION_NUM * formatting * prevent declarations of globals in Lua scripts * fix tests * add LuaLoggingMode option; redis.log(...) now gets recorded, but can be disabled (either silently, or raising and error) if desired * fix benchmarks * fix benchmarks * Fix SET KEEPTTL return string (#1039) * SETKEEPTTL (no other flags) should always return ok. It doesn't care about NX or XX * Simplify GETSET --------- Co-authored-by: prvyk <[email protected]> Co-authored-by: Tal Zaccai <[email protected]> * Support for Diskless Replication (#997) * expose diskless replication parameters * refactor/cleanup legacy ReplicaSyncSession * add interface to support diskless replication session and aof tasks * core diskless replication implementation * expose diskless replication API * adding test for diskless replication * update gcs extension to clearly mark logging progress * fix gcs dispose on diskless attach, call dispose of replicationSyncManager, add more logging * complete first diskless replication test * fix iterator check for null when empty store * fix iterator for object store cluster sync * add simple diskless sync test * cleanup code * replica fall behind test * wip * register cts at wait for sync completion * add db version alignment test * avoid using close lock for leader based syncing * truncate AOF after streaming checkpoint is taken * add tests for failover with diskless replication * fix formatting and conversion to IPEndpoint * fix RepCommandsTests * dispose aofSyncTask if failed to add to AofSyncTaskStore * overload dispose ReplicaSyncSession * explicitly dispose gcs used for full sync at replicaSyncSession sync * dispose gcs once on return * code cleanup * update tests to provide more context logging * add more comprehensive logging of syncMetadata * add timeout for streaming checkpoint * add clusterTimeout for diskless repl tests * some more logging * cleanup and refactor code * truncate AOF only when main-memory-replication is switched on * adding logging for cancellation when streaming * split checkpoint commit marker to allow for disk checkpoints * update sync metadata log message * add progress based timeout implementation * deprecate main-memory-replication * formatting * prevent declarations of globals in Lua scripts * fix tests * add LuaLoggingMode option; redis.log(...) now gets recorded, but can be disabled (either silently, or raising and error) if desired * fix benchmarks * fix benchmarks * bit of sandbox_env cleanup * Allow redis.setresp(3); this allows a mix of RESP(2|3) for connections and inner sessions. Lots of testing, comparing against Redis. Fixes RESP3 behavior of HGETALL, SDIFF, ZSCORE (more fixes for other commands needed in separate PR). * fix null ref when there's not underlying session * limit size of log in LuaScriptTests * cleanup this constant string registry stuff * convert a couple PushBuffers to PushConstantStrings * serializing logger access in LuaScriptTests * address feedback * remove more bogus usings --------- Co-authored-by: prvyk <[email protected]> Co-authored-by: prvyk <[email protected]> Co-authored-by: Tal Zaccai <[email protected]> Co-authored-by: Vasileios Zois <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SET KEEPTTL (no other flags) should always return 'OK', it doesn't care about NX/XX. Code did XX style return by accident.