-
Notifications
You must be signed in to change notification settings - Fork 169
Fix dependencies, create config packages, and implement depcheck --fix-errors #3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a2bfc62
create a more robust depcheck implementation
JasonVMo 0a19faa
fix missing eslint config dependencies
JasonVMo cc464e2
apply depcheck fix to directories to fix error level issues
JasonVMo 271699d
fix missing deps for private packages
JasonVMo a9fc3a2
applying package updates
UI-Fabric-RN-Bot 8440fa2
JSX runtime (part 2 of 3) - more formal rendering logic for both clas…
JasonVMo 5076751
applying package updates
UI-Fabric-RN-Bot b9aa67b
apply more dependency fixes
JasonVMo fb9d675
JSX runtime (part 2 of 3) - more formal rendering logic for both clas…
JasonVMo 7d54e98
applying package updates
UI-Fabric-RN-Bot 0494df9
Merge remote-tracking branch 'origin/main' into user/jasonvmo/deps
JasonVMo 24a8f09
switch to pnpm and fix to build stage
JasonVMo 18c1435
fix dependencies up through linting
JasonVMo caded41
fix babel and jest configs and add dedicated babel config package
JasonVMo 9b614c5
split jest configurations into a separate package
JasonVMo 2366a6a
fix more tests
JasonVMo 6e24494
move repo to pnpm, create babel and jest config packages, fix depende…
JasonVMo fabe04b
Change files
JasonVMo e27726a
add missing @types/jest devDependency
JasonVMo 495139d
fix ios/mac pod install
JasonVMo 3ac02b8
fix align-deps issue
JasonVMo febbb2e
fix more align-deps / depcheck issues
JasonVMo 8800909
switch back to node-modules temporarily to deal with appium issues as…
JasonVMo 8d122ae
add build fixes for node-modules linking
JasonVMo 3f432ce
revert podfiles to non-pnpm behavior, fix prettier issues, respond to…
JasonVMo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
apps/component-generator/component-templates/ComponentTemplate/babel.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| module.exports = require('@fluentui-react-native/scripts/configs/babel.config'); | ||
| module.exports = require('@fluentui-react-native/babel-config'); |
2 changes: 1 addition & 1 deletion
2
apps/component-generator/component-templates/ComponentTemplate/jest.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| const { configureReactNativeJest } = require('@fluentui-react-native/scripts'); | ||
| const { configureReactNativeJest } = require('@fluentui-react-native/jest-config'); | ||
| module.exports = configureReactNativeJest('android'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| # (pnpm-mode) ENV['REACT_NATIVE_NODE_MODULES_DIR'] = File.join(__dir__, '../node_modules') | ||
|
|
||
| # (pnpm-mode) require_relative '../node_modules/react-native-test-app/test_app' | ||
| require_relative '../../../node_modules/react-native-test-app/test_app' | ||
|
|
||
| workspace 'FluentTester.xcworkspace' | ||
|
|
||
| # (pnpm-mode) react_native_path = "#{__dir__}/../node_modules/react-native" | ||
| react_native_path = "#{__dir__}/../../../node_modules/react-native" | ||
|
|
||
| use_test_app! do |target| | ||
| target.app do | ||
| platform :ios, '15.0' | ||
|
|
||
| # There is a bug where autolinking isn't working, so specify these manually. | ||
| pod 'FRNAppearanceAdditions', :path => '../../../packages/experimental/AppearanceAdditions/FRNAppearanceAdditions.podspec' | ||
| pod 'FRNFontMetrics', :path => '../../../packages/experimental/NativeFontMetrics/FRNFontMetrics.podspec' | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,15 @@ | ||
| # (pnpm-mode) ENV['REACT_NATIVE_NODE_MODULES_DIR'] = File.join(__dir__, '../node_modules') | ||
|
|
||
| # require_relative '../node_modules/react-native-test-app/macos/test_app' | ||
| require_relative '../../../node_modules/react-native-test-app/macos/test_app' | ||
|
|
||
| workspace 'FluentTester.xcworkspace' | ||
|
|
||
| # (pnpm-mode) react_native_path = "#{__dir__}/../node_modules/react-native" | ||
| react_native_path = "#{__dir__}/../../../node_modules/react-native" | ||
|
|
||
| use_test_app! do |target| | ||
| target.app do | ||
| platform :osx, '12' | ||
|
|
||
| # There is a bug where autolinking isn't working, do specify these manually. | ||
| pod 'FRNAvatar', :path => '../../../packages/experimental/Avatar/FRNAvatar.podspec' | ||
| pod 'FRNCheckbox', :path => '../../../packages/experimental/Checkbox/FRNCheckbox.podspec' | ||
| pod 'FRNMenuButton', :path => '../../../packages/components/MenuButton/FRNMenuButton.podspec' | ||
| pod 'FRNRadioButton', :path => '../../../packages/components/RadioGroup/FRNRadioButton.podspec' | ||
| pod 'RCTFocusZone', :path => '../../../packages/components/FocusZone/RCTFocusZone.podspec' | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.