Skip to content

Introduce settingId for GlobalMessage and clarify purpose for GlobalDialog #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

Introduce settingId for GlobalMessage and clarify purpose for GlobalDialog #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Common/CommonServices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,11 @@ export interface IGlobalMessageBanner {
* Links to supply to the format arguments in `messageFormat`
*/
messageLinks?: IGlobalMessageLink[];

/**
* The id used to check if the banner has been dismissed, and make dismissal permanent
*/
settingId?: string;
}

/**
Expand Down Expand Up @@ -711,7 +716,7 @@ export interface IGlobalDialog {
priority?: number;

/**
* The id used to check if the dialog has been dismissed.
* The id used to check if the dialog has been dismissed, and make dismissal permanent.
*/
settingId?: string;

Expand Down Expand Up @@ -850,4 +855,4 @@ export interface IContributedPill {
* Optional value to use as an aria-label and tooltip for the pill.
*/
tooltip?: string;
}
}