Skip to content

.NET: ADR: Supporting user approvals #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 72 commits into from
Closed

.NET: ADR: Supporting user approvals #209

Changes from 15 commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
c73282b
ADR: Supporting user approvals
westey-m Jul 22, 2025
9e3b98b
Add more context.
westey-m Jul 22, 2025
a9a6a97
Add further justification
westey-m Jul 22, 2025
61063c0
Add decision drivers.
westey-m Jul 22, 2025
3a0dabf
Update with Copilot Suggestion
westey-m Jul 22, 2025
786374c
Merge branch 'main' into userapproval-adr
westey-m Jul 23, 2025
eace4e7
Update adr with feedback.
westey-m Jul 23, 2025
4076ed3
Adding another generalized option for all user input.
westey-m Jul 23, 2025
23b4fe5
Merge branch 'main' into userapproval-adr
westey-m Jul 24, 2025
12817f1
Add another base class based UserInput option
westey-m Jul 25, 2025
84e2855
Remove TextContent inheritance.
westey-m Jul 25, 2025
632635c
Change Schema and Strucutured input data types to JsonElement
westey-m Jul 25, 2025
461c8ef
Rename JsonSchema to Schema
westey-m Jul 25, 2025
7de1787
Merge branch 'main' into userapproval-adr
westey-m Jul 29, 2025
aa3c14e
Merge branch 'main' into userapproval-adr
crickman Jul 30, 2025
ab04590
Address some feedback.
westey-m Jul 30, 2025
aba7dc6
Merge branch 'main' into userapproval-adr
westey-m Jul 30, 2025
89ff266
Merge branch 'main' into userapproval-adr
crickman Jul 30, 2025
629204e
Add base user input request and response types with FunctionApproval …
westey-m Jul 31, 2025
3783074
Merge branch 'main' into userapproval-adr
crickman Jul 31, 2025
d3a9319
Merge branch 'main' into userapproval-adr
westey-m Aug 1, 2025
74d1f5d
Add POC ApprovalGeneratingChatClient
westey-m Aug 1, 2025
3c40615
Merge branch 'main' into userapproval-adr
crickman Aug 5, 2025
c068247
Add pre-FunctionInvokingChatClient ApprovalGeneratingChatClient POC
westey-m Aug 5, 2025
d8626a4
Merge branch 'userapproval-adr' of https://github.com/westey-m/agent-…
westey-m Aug 5, 2025
45254f3
Merge branch 'main' into userapproval-adr
westey-m Aug 5, 2025
3300dce
Merge branch 'main' into userapproval-adr
westey-m Aug 6, 2025
c8e42de
Fix namespaces
westey-m Aug 6, 2025
97352a0
Add combined FICC with approvals
westey-m Aug 7, 2025
2c39648
Bug fix.
westey-m Aug 7, 2025
5293568
Add MCP and ApprovalRequiredAIFunction POC
westey-m Aug 8, 2025
c5bedd0
Bug fixes
westey-m Aug 11, 2025
edcad34
Address PR Feedback.
westey-m Aug 11, 2025
0a61294
Add AIFunctionApprovalContext with some small efficiency improvements.
westey-m Aug 11, 2025
436c490
Remove unecessary helpers that are only used in one place.
westey-m Aug 11, 2025
0d5fcbf
Replace dictionary with array and lazy initialize.
westey-m Aug 11, 2025
8beb0f6
Improve sample code
westey-m Aug 11, 2025
9fbd0a7
Make user input id required and rename it to be more general.
westey-m Aug 12, 2025
302d43d
Merge branch 'main' into userapproval-adr
westey-m Aug 12, 2025
8ad466b
Upgrade packages to resolve conflicts.
westey-m Aug 12, 2025
049c9d3
Move some code into methods to simply main GetResponse.
westey-m Aug 12, 2025
39ef6bd
Adding approvals support to streaming
westey-m Aug 13, 2025
14d4773
Address PR comments.
westey-m Aug 13, 2025
b288fed
Change approval response type and naming
westey-m Aug 13, 2025
fc0bf74
Remove commented out validation checks that won't work for server sid…
westey-m Aug 13, 2025
d1939ad
Remove original metadata and read metadata from approval request mess…
westey-m Aug 14, 2025
6d8b20e
Small code refactoring and clarifying comments.
westey-m Aug 14, 2025
2bc90af
Remove failed POCs
westey-m Aug 14, 2025
d12cdf8
Update ADR with latest changes
westey-m Aug 14, 2025
3420337
Explain case when pre FICC AGCC fails
westey-m Aug 14, 2025
6a6f9dd
Add support for mcp servers over http.
westey-m Aug 14, 2025
f05bf90
Merge branch 'main' into userapproval-adr
westey-m Aug 14, 2025
3105941
Addressing PR comments.
westey-m Aug 15, 2025
26eb742
Address PR comments
westey-m Aug 15, 2025
0adf519
Merge branch 'main' into userapproval-adr
westey-m Aug 15, 2025
b2a4915
Merge latest updates from main
westey-m Aug 15, 2025
5e52c11
Add FICC unit tests and fix bugs.
westey-m Aug 19, 2025
b1289e3
Add additional unit test.
westey-m Aug 19, 2025
0b4405e
Refactor ConvertToFunctionCallContentMessages to avoid unecessary all…
westey-m Aug 20, 2025
545c231
Refactor preinvocation logic to share between streaming and non-strea…
westey-m Aug 20, 2025
e6aeebb
Move some approval generation code to a separate method to simplify m…
westey-m Aug 20, 2025
a1b2973
More refactoring, additional unit tests and bug fixes.
westey-m Aug 20, 2025
906ad2f
Remove comments delineating additions.
westey-m Aug 20, 2025
4c59b25
Merge latest changes from main
westey-m Aug 20, 2025
66b904e
Fixing some typos.
westey-m Aug 20, 2025
d3dd02e
Merge branch 'main' into userapproval-adr
westey-m Aug 21, 2025
21680be
Address PR comments.
westey-m Aug 22, 2025
a712408
Address PR comments.
westey-m Aug 22, 2025
c1da46b
Address PR feedback.
westey-m Aug 22, 2025
091f754
Fix bug for server side threads.
westey-m Aug 22, 2025
7518b70
Address PR comments
westey-m Aug 25, 2025
a349c79
Merge from main
westey-m Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading