Skip to content

Remove unused and confusing dom.iterable.d.ts file #62037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

Remove unused and confusing dom.iterable.d.ts file #62037

merged 1 commit into from
Jul 21, 2025

Conversation

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Jul 10, 2025 •
edited
Loading

This file is entirely unused, since dom.iterable.generated.d.ts is copied instead.

But this does mean that the DOM lib generator is missing references.

Copilot AI review requested due to automatic review settings July 10, 2025 17:50
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jul 10, 2025
Copilot AI reviewed Jul 10, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 10, 2025
@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jul 21, 2025
@jakebailey jakebailey merged commit f14b5c8 into microsoft:main Jul 21, 2025
57 of 58 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jul 21, 2025
@jakebailey jakebailey deleted the remove-ghost-dom-iterable branch July 21, 2025 21:30
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.9.1 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees

@jakebailey jakebailey

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Status: Done

Milestone

TypeScript 5.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@jakebailey @RyanCavanaugh @DanielRosenwasser @typescript-bot