Skip to content

Move deprecate from Debug to deprecatedCompat #51522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2022
Merged

Move deprecate from Debug to deprecatedCompat #51522

merged 2 commits into from
Nov 16, 2022

Conversation

@jakebailey
Copy link
Member

For #51443, #51441

This breaks the cycle between Debug and Version; while the current state doesn't crash (both bundled and unbundled), it only works due to some careful setup done in #51387. It's possible for a future refactor to break this unintentionally.

This was pulled out of #51455. It's a prerequisite for potentially making Debug a module rather than a namespace but probably also useful for #51504.

It also happens to reduce the code size of tsc by a little, since it doesn't use this code, but it's not really a significant amount by any means and isn't the driving force behind the PR.

@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 14, 2022
@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 14, 2022 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 89722f1. You can monitor the build here.

Update: The results are in!

@jakebailey jakebailey changed the title Move deprecate to deprecatedCompat Move deprecate from Debug to deprecatedCompat Nov 14, 2022
@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51522
Metric main 51522 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 341,214k (± 0.01%) 341,148k (± 0.01%) -66k (- 0.02%) 341,014k 341,253k
Parse Time 1.57s (± 0.88%) 1.56s (± 0.65%) -0.01s (- 0.51%) 1.54s 1.58s
Bind Time 0.54s (± 0.92%) 0.53s (± 0.84%) -0.00s (- 0.75%) 0.52s 0.54s
Check Time 4.05s (± 0.79%) 4.02s (± 0.71%) -0.03s (- 0.74%) 3.95s 4.09s
Emit Time 4.27s (± 0.84%) 4.26s (± 0.40%) -0.01s (- 0.33%) 4.20s 4.28s
Total Time 10.43s (± 0.66%) 10.37s (± 0.28%) -0.06s (- 0.54%) 10.30s 10.44s
Compiler-Unions - node (v18.10.0, x64)
Memory used 188,819k (± 1.03%) 189,798k (± 0.65%) +979k (+ 0.52%) 184,902k 190,520k
Parse Time 0.62s (± 1.07%) 0.62s (± 1.10%) -0.00s (- 0.65%) 0.61s 0.64s
Bind Time 0.33s (± 0.68%) 0.33s (± 1.58%) 0.00s ( 0.00%) 0.32s 0.34s
Check Time 5.01s (± 0.57%) 5.02s (± 0.74%) +0.01s (+ 0.18%) 4.97s 5.11s
Emit Time 1.55s (± 2.41%) 1.52s (± 0.43%) -0.03s (- 2.00%) 1.51s 1.54s
Total Time 7.51s (± 0.54%) 7.49s (± 0.60%) -0.03s (- 0.35%) 7.42s 7.61s
Monaco - node (v18.10.0, x64)
Memory used 320,524k (± 0.01%) 320,540k (± 0.05%) +16k (+ 0.00%) 320,322k 321,133k
Parse Time 1.18s (± 1.38%) 1.16s (± 1.40%) -0.02s (- 1.86%) 1.13s 1.20s
Bind Time 0.49s (± 1.91%) 0.49s (± 2.49%) -0.00s (- 0.81%) 0.47s 0.51s
Check Time 3.88s (± 0.60%) 3.83s (± 0.40%) -0.05s (- 1.21%) 3.80s 3.87s
Emit Time 2.28s (± 1.00%) 2.23s (± 0.85%) -0.05s (- 2.11%) 2.19s 2.28s
Total Time 7.83s (± 0.50%) 7.71s (± 0.41%) -0.12s (- 1.52%) 7.65s 7.79s
TFS - node (v18.10.0, x64)
Memory used 283,538k (± 0.24%) 283,714k (± 0.25%) +177k (+ 0.06%) 282,789k 284,978k
Parse Time 0.97s (± 1.07%) 0.96s (± 1.49%) -0.01s (- 1.34%) 0.93s 0.99s
Bind Time 0.45s (± 6.14%) 0.46s (± 7.33%) +0.01s (+ 2.22%) 0.43s 0.55s
Check Time 3.80s (± 0.59%) 3.77s (± 0.49%) -0.04s (- 0.95%) 3.73s 3.80s
Emit Time 2.22s (± 0.85%) 2.18s (± 0.74%) -0.04s (- 1.76%) 2.15s 2.23s
Total Time 7.44s (± 0.72%) 7.36s (± 0.57%) -0.08s (- 1.05%) 7.27s 7.44s
material-ui - node (v18.10.0, x64)
Memory used 436,031k (± 0.02%) 435,975k (± 0.01%) -56k (- 0.01%) 435,912k 436,128k
Parse Time 1.35s (± 0.78%) 1.33s (± 0.75%) -0.02s (- 1.48%) 1.31s 1.35s
Bind Time 0.50s (± 0.73%) 0.49s (± 0.91%) -0.00s (- 0.81%) 0.48s 0.50s
Check Time 10.40s (± 0.56%) 10.24s (± 0.70%) -0.16s (- 1.52%) 10.12s 10.50s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 12.25s (± 0.52%) 12.07s (± 0.67%) -0.18s (- 1.48%) 11.95s 12.36s
xstate - node (v18.10.0, x64)
Memory used 518,685k (± 0.01%) 518,657k (± 0.02%) -28k (- 0.01%) 518,538k 518,897k
Parse Time 1.94s (± 0.31%) 1.91s (± 0.63%) -0.03s (- 1.59%) 1.89s 1.94s
Bind Time 0.79s (± 4.16%) 0.78s (± 2.73%) -0.01s (- 1.39%) 0.72s 0.82s
Check Time 1.06s (± 0.96%) 1.03s (± 0.54%) -0.02s (- 2.18%) 1.02s 1.04s
Emit Time 0.05s (± 0.00%) 0.05s (± 0.00%) 0.00s ( 0.00%) 0.05s 0.05s
Total Time 3.84s (± 0.92%) 3.77s (± 0.79%) -0.07s (- 1.82%) 3.71s 3.83s
Angular - node (v16.17.1, x64)
Memory used 340,522k (± 0.02%) 340,536k (± 0.02%) +14k (+ 0.00%) 340,335k 340,650k
Parse Time 1.88s (± 0.66%) 1.87s (± 0.53%) -0.01s (- 0.74%) 1.85s 1.89s
Bind Time 0.65s (± 0.89%) 0.64s (± 0.53%) -0.01s (- 1.53%) 0.64s 0.65s
Check Time 5.16s (± 0.38%) 5.12s (± 0.45%) -0.04s (- 0.81%) 5.07s 5.17s
Emit Time 5.11s (± 0.76%) 5.07s (± 0.74%) -0.04s (- 0.72%) 4.99s 5.14s
Total Time 12.81s (± 0.46%) 12.70s (± 0.44%) -0.10s (- 0.81%) 12.57s 12.81s
Compiler-Unions - node (v16.17.1, x64)
Memory used 188,257k (± 0.65%) 187,881k (± 0.63%) -376k (- 0.20%) 186,478k 189,898k
Parse Time 0.79s (± 0.75%) 0.79s (± 1.27%) 0.00s ( 0.00%) 0.78s 0.82s
Bind Time 0.42s (± 0.53%) 0.42s (± 0.71%) -0.00s (- 0.71%) 0.41s 0.42s
Check Time 6.05s (± 0.72%) 6.04s (± 0.87%) -0.01s (- 0.13%) 5.97s 6.21s
Emit Time 1.91s (± 0.72%) 1.90s (± 1.12%) -0.00s (- 0.21%) 1.83s 1.94s
Total Time 9.17s (± 0.47%) 9.16s (± 0.64%) -0.01s (- 0.15%) 9.06s 9.35s
Monaco - node (v16.17.1, x64)
Memory used 319,866k (± 0.01%) 319,840k (± 0.01%) -26k (- 0.01%) 319,779k 319,922k
Parse Time 1.43s (± 0.73%) 1.42s (± 0.67%) -0.01s (- 0.77%) 1.40s 1.44s
Bind Time 0.59s (± 1.00%) 0.59s (± 0.76%) -0.01s (- 1.01%) 0.58s 0.60s
Check Time 4.87s (± 0.39%) 4.85s (± 0.54%) -0.02s (- 0.41%) 4.79s 4.89s
Emit Time 2.72s (± 0.90%) 2.71s (± 0.98%) -0.01s (- 0.37%) 2.64s 2.75s
Total Time 9.61s (± 0.40%) 9.57s (± 0.57%) -0.05s (- 0.49%) 9.42s 9.65s
TFS - node (v16.17.1, x64)
Memory used 282,300k (± 0.01%) 282,298k (± 0.00%) -3k (- 0.00%) 282,280k 282,330k
Parse Time 1.17s (± 0.51%) 1.17s (± 0.95%) +0.00s (+ 0.09%) 1.14s 1.19s
Bind Time 0.65s (± 3.63%) 0.65s (± 3.48%) -0.00s (- 0.15%) 0.60s 0.69s
Check Time 4.76s (± 0.39%) 4.73s (± 0.25%) -0.03s (- 0.63%) 4.70s 4.76s
Emit Time 2.76s (± 2.01%) 2.73s (± 1.68%) -0.03s (- 1.05%) 2.66s 2.85s
Total Time 9.35s (± 0.72%) 9.28s (± 0.51%) -0.07s (- 0.74%) 9.19s 9.41s
material-ui - node (v16.17.1, x64)
Memory used 435,297k (± 0.01%) 435,307k (± 0.01%) +10k (+ 0.00%) 435,259k 435,490k
Parse Time 1.65s (± 0.50%) 1.64s (± 0.81%) -0.01s (- 0.85%) 1.62s 1.68s
Bind Time 0.50s (± 0.98%) 0.50s (± 1.12%) -0.01s (- 1.19%) 0.49s 0.51s
Check Time 11.96s (± 0.42%) 11.90s (± 0.91%) -0.07s (- 0.54%) 11.65s 12.10s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.13s (± 0.36%) 14.04s (± 0.84%) -0.09s (- 0.61%) 13.78s 14.22s
xstate - node (v16.17.1, x64)
Memory used 516,263k (± 0.01%) 516,232k (± 0.01%) -32k (- 0.01%) 516,135k 516,372k
Parse Time 2.33s (± 0.45%) 2.31s (± 0.39%) -0.02s (- 0.90%) 2.29s 2.33s
Bind Time 0.84s (± 1.90%) 0.83s (± 0.70%) -0.02s (- 2.01%) 0.82s 0.84s
Check Time 1.36s (± 0.50%) 1.36s (± 0.70%) +0.00s (+ 0.00%) 1.33s 1.37s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 4.60s (± 0.44%) 4.55s (± 0.37%) -0.04s (- 0.91%) 4.51s 4.59s
Angular - node (v14.15.1, x64)
Memory used 334,041k (± 0.01%) 334,030k (± 0.01%) -11k (- 0.00%) 334,008k 334,075k
Parse Time 2.08s (± 0.55%) 2.04s (± 0.59%) -0.04s (- 1.97%) 2.02s 2.07s
Bind Time 0.70s (± 0.53%) 0.70s (± 0.82%) -0.01s (- 0.71%) 0.69s 0.71s
Check Time 5.52s (± 0.33%) 5.47s (± 0.47%) -0.05s (- 0.94%) 5.43s 5.53s
Emit Time 5.22s (± 0.68%) 5.19s (± 0.67%) -0.03s (- 0.63%) 5.12s 5.27s
Total Time 13.53s (± 0.38%) 13.40s (± 0.33%) -0.13s (- 0.95%) 13.29s 13.49s
Compiler-Unions - node (v14.15.1, x64)
Memory used 181,579k (± 0.01%) 181,563k (± 0.01%) -16k (- 0.01%) 181,522k 181,601k
Parse Time 0.90s (± 0.62%) 0.89s (± 0.41%) -0.01s (- 1.34%) 0.88s 0.89s
Bind Time 0.46s (± 0.48%) 0.45s (± 0.99%) -0.01s (- 1.95%) 0.44s 0.46s
Check Time 6.36s (± 0.45%) 6.30s (± 0.46%) -0.07s (- 1.05%) 6.26s 6.38s
Emit Time 2.04s (± 0.71%) 2.04s (± 0.52%) -0.01s (- 0.39%) 2.01s 2.07s
Total Time 9.77s (± 0.35%) 9.67s (± 0.33%) -0.10s (- 1.02%) 9.61s 9.75s
Monaco - node (v14.15.1, x64)
Memory used 314,689k (± 0.05%) 314,571k (± 0.01%) -118k (- 0.04%) 314,472k 314,650k
Parse Time 1.58s (± 0.66%) 1.56s (± 0.48%) -0.02s (- 1.01%) 1.55s 1.58s
Bind Time 0.64s (± 0.78%) 0.63s (± 0.71%) -0.00s (- 0.47%) 0.62s 0.64s
Check Time 5.21s (± 0.52%) 5.17s (± 0.44%) -0.04s (- 0.77%) 5.09s 5.22s
Emit Time 2.92s (± 0.69%) 2.87s (± 1.00%) -0.05s (- 1.64%) 2.82s 2.94s
Total Time 10.34s (± 0.41%) 10.23s (± 0.44%) -0.11s (- 1.05%) 10.12s 10.31s
TFS - node (v14.15.1, x64)
Memory used 279,310k (± 0.01%) 279,314k (± 0.01%) +5k (+ 0.00%) 279,281k 279,346k
Parse Time 1.34s (± 0.62%) 1.33s (± 1.56%) -0.01s (- 0.67%) 1.29s 1.40s
Bind Time 0.59s (± 0.80%) 0.58s (± 0.63%) -0.01s (- 0.85%) 0.58s 0.59s
Check Time 5.10s (± 0.36%) 5.06s (± 0.49%) -0.04s (- 0.88%) 4.99s 5.11s
Emit Time 3.08s (± 0.92%) 3.04s (± 1.92%) -0.05s (- 1.59%) 2.84s 3.13s
Total Time 10.12s (± 0.34%) 10.01s (± 0.72%) -0.11s (- 1.08%) 9.80s 10.13s
material-ui - node (v14.15.1, x64)
Memory used 430,756k (± 0.01%) 430,747k (± 0.00%) -9k (- 0.00%) 430,695k 430,786k
Parse Time 1.88s (± 0.46%) 1.87s (± 0.35%) -0.01s (- 0.74%) 1.85s 1.88s
Bind Time 0.54s (± 0.69%) 0.53s (± 0.63%) -0.01s (- 0.93%) 0.52s 0.54s
Check Time 12.38s (± 0.70%) 12.17s (± 0.33%) -0.21s (- 1.67%) 12.08s 12.29s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.79s (± 0.60%) 14.57s (± 0.26%) -0.23s (- 1.55%) 14.47s 14.66s
xstate - node (v14.15.1, x64)
Memory used 504,439k (± 0.00%) 504,425k (± 0.01%) -14k (- 0.00%) 504,361k 504,509k
Parse Time 2.65s (± 0.70%) 2.63s (± 0.63%) -0.03s (- 1.02%) 2.59s 2.68s
Bind Time 0.86s (± 0.97%) 0.84s (± 0.99%) -0.02s (- 2.22%) 0.82s 0.86s
Check Time 1.49s (± 0.35%) 1.47s (± 0.54%) -0.02s (- 1.14%) 1.45s 1.49s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.07s (± 0.30%) 5.00s (± 0.33%) -0.07s (- 1.28%) 4.97s 5.04s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51522 10
Baseline main 10

TSServer

Comparison Report - main..51522
Metric main 51522 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,047ms (± 0.50%) 1,044ms (± 0.68%) -2ms (- 0.21%) 1,034ms 1,067ms
Req 2 - geterr 2,568ms (± 0.75%) 2,536ms (± 0.62%) -32ms (- 1.24%) 2,499ms 2,572ms
Req 3 - references 166ms (± 0.99%) 165ms (± 0.42%) -1ms (- 0.36%) 163ms 166ms
Req 4 - navto 138ms (± 0.94%) 139ms (± 2.91%) +1ms (+ 1.02%) 135ms 155ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 62ms (± 2.71%) 61ms (± 1.45%) -1ms (- 1.46%) 58ms 62ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,102ms (± 0.50%) 1,093ms (± 0.55%) -9ms (- 0.77%) 1,080ms 1,103ms
Req 2 - geterr 1,573ms (± 0.39%) 1,562ms (± 0.36%) -11ms (- 0.69%) 1,549ms 1,577ms
Req 3 - references 171ms (± 0.98%) 169ms (± 0.49%) -3ms (- 1.46%) 167ms 170ms
Req 4 - navto 151ms (± 0.88%) 150ms (± 0.50%) -1ms (- 0.53%) 149ms 152ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 53ms (± 1.46%) 53ms (± 1.05%) -0ms (- 0.56%) 52ms 54ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,518ms (± 0.76%) 1,507ms (± 0.49%) -11ms (- 0.73%) 1,496ms 1,525ms
Req 2 - geterr 562ms (± 0.53%) 551ms (± 0.79%) -11ms (- 1.99%) 545ms 564ms
Req 3 - references 59ms (± 2.01%) 58ms (± 2.04%) -1ms (- 1.69%) 57ms 62ms
Req 4 - navto 197ms (± 1.03%) 195ms (± 0.51%) -2ms (- 1.02%) 193ms 197ms
Req 5 - completionInfo count 3,151 (± 0.00%) 3,151 (± 0.00%) 0 ( 0.00%) 3,151 3,151
Req 5 - completionInfo 212ms (± 1.32%) 212ms (± 1.33%) -0ms (- 0.14%) 207ms 219ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,303ms (± 0.79%) 1,296ms (± 0.55%) -7ms (- 0.52%) 1,275ms 1,309ms
Req 2 - geterr 3,153ms (± 0.65%) 3,152ms (± 0.76%) -1ms (- 0.04%) 3,115ms 3,207ms
Req 3 - references 193ms (± 1.37%) 193ms (± 1.18%) -0ms (- 0.16%) 188ms 198ms
Req 4 - navto 151ms (± 0.70%) 151ms (± 0.76%) -0ms (- 0.13%) 149ms 153ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 59ms (± 2.55%) 58ms (± 2.16%) -1ms (- 1.37%) 55ms 61ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,394ms (± 0.70%) 1,375ms (± 0.92%) -20ms (- 1.42%) 1,346ms 1,403ms
Req 2 - geterr 2,072ms (± 0.44%) 2,060ms (± 0.51%) -12ms (- 0.56%) 2,031ms 2,074ms
Req 3 - references 199ms (± 0.56%) 200ms (± 0.45%) +0ms (+ 0.10%) 198ms 201ms
Req 4 - navto 165ms (± 0.62%) 164ms (± 0.98%) -1ms (- 0.79%) 161ms 168ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 58ms (± 2.78%) 58ms (± 1.97%) +0ms (+ 0.35%) 54ms 59ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,819ms (± 0.36%) 1,821ms (± 0.51%) +1ms (+ 0.08%) 1,807ms 1,843ms
Req 2 - geterr 713ms (± 0.54%) 714ms (± 0.98%) +1ms (+ 0.15%) 699ms 728ms
Req 3 - references 69ms (± 1.39%) 68ms (± 2.44%) -1ms (- 1.02%) 65ms 73ms
Req 4 - navto 197ms (± 1.11%) 197ms (± 0.97%) 0ms ( 0.00%) 194ms 204ms
Req 5 - completionInfo count 3,151 (± 0.00%) 3,151 (± 0.00%) 0 ( 0.00%) 3,151 3,151
Req 5 - completionInfo 251ms (± 0.95%) 253ms (± 0.84%) +1ms (+ 0.56%) 249ms 257ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,461ms (± 0.44%) 1,446ms (± 0.52%) -16ms (- 1.07%) 1,433ms 1,463ms
Req 2 - geterr 3,426ms (± 0.65%) 3,380ms (± 0.61%) -46ms (- 1.34%) 3,339ms 3,440ms
Req 3 - references 206ms (± 0.55%) 206ms (± 0.46%) -1ms (- 0.29%) 204ms 209ms
Req 4 - navto 162ms (± 0.90%) 163ms (± 2.01%) +0ms (+ 0.18%) 159ms 175ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 66ms (± 6.92%) 66ms (± 5.93%) +0ms (+ 0.46%) 58ms 72ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,530ms (± 0.58%) 1,520ms (± 0.34%) -10ms (- 0.65%) 1,514ms 1,538ms
Req 2 - geterr 2,262ms (± 0.29%) 2,240ms (± 0.54%) -23ms (- 0.99%) 2,224ms 2,283ms
Req 3 - references 213ms (± 1.28%) 212ms (± 1.31%) -1ms (- 0.52%) 208ms 219ms
Req 4 - navto 174ms (± 0.77%) 173ms (± 1.01%) -2ms (- 1.09%) 169ms 177ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 61ms (± 7.63%) 61ms (± 8.47%) -1ms (- 1.14%) 55ms 71ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,037ms (± 0.62%) 2,007ms (± 0.32%) -30ms (- 1.45%) 1,993ms 2,024ms
Req 2 - geterr 751ms (± 0.58%) 739ms (± 0.46%) -13ms (- 1.68%) 731ms 746ms
Req 3 - references 73ms (± 1.16%) 72ms (± 1.25%) -1ms (- 1.92%) 70ms 74ms
Req 4 - navto 222ms (± 0.64%) 217ms (± 0.54%) -5ms (- 2.25%) 214ms 220ms
Req 5 - completionInfo count 3,151 (± 0.00%) 3,151 (± 0.00%) 0 ( 0.00%) 3,151 3,151
Req 5 - completionInfo 270ms (± 0.57%) 271ms (± 1.62%) +2ms (+ 0.59%) 265ms 280ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51522 10
Baseline main 10

Startup

Comparison Report - main..51522
Metric main 51522 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 120.22ms (± 0.53%) 118.29ms (± 0.48%) -1.93ms (- 1.61%) 115.71ms 125.21ms
tsserver-startup - node (v16.17.1, x64)
Execution time 201.76ms (± 0.47%) 198.37ms (± 0.33%) -3.39ms (- 1.68%) 195.28ms 206.00ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 194.36ms (± 0.46%) 192.32ms (± 0.34%) -2.05ms (- 1.05%) 189.05ms 200.71ms
typescript-startup - node (v16.17.1, x64)
Execution time 178.93ms (± 0.45%) 177.28ms (± 0.30%) -1.65ms (- 0.92%) 174.78ms 184.40ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51522 10
Baseline main 10

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

Going to merge this to unblock the other PRs; if we need to reintroduce this into the compiler project we can do so but I this is okay.

@jakebailey jakebailey merged commit 4d53a1f into microsoft:main Nov 16, 2022
@jakebailey jakebailey deleted the move-deprecation branch November 16, 2022 00:00
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees

@jakebailey jakebailey

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jakebailey @typescript-bot @DanielRosenwasser @sheetalkamat