Skip to content

🤖 Pick PR #45484 (Fixed JS completions type spread) into release-4.4 #45564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

🤖 Pick PR #45484 (Fixed JS completions type spread) into release-4.4 #45564

merged 1 commit into from
Aug 30, 2021

Conversation

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Aug 24, 2021

This cherry-pick was triggered by a request on #45484
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.

cc @andrewbranch

@armanio123 @typescript-bot
Cherry-pick PR microsoft#45484 into release-4.4
0add5a8 
Component commits:
33829fa Fix and updated tests

2249d6c Added test

e1a2b9e Revert "Fix and updated tests"
This reverts commit 33829fa.

51881c4 Filter out empty access expression

2253da6 PR feedback
@typescript-bot typescript-bot mentioned this pull request Aug 24, 2021
Merged
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 24, 2021
@andrewbranch
Copy link
Member

andrewbranch commented Aug 25, 2021

Waiting for 4.4.2 (stable) to be released; this will go into 4.4.3.

@DanielRosenwasser DanielRosenwasser merged commit 782c09d into microsoft:release-4.4 Aug 30, 2021
@andrewbranch andrewbranch added this to the TypeScript 4.4.3 milestone Sep 10, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@armanio123 armanio123 armanio123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

TypeScript 4.4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@typescript-bot @andrewbranch @armanio123 @DanielRosenwasser