Restore HTMLDocument constructable value in DOM #45554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't touch anything else in the DOM.
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
approved these changes
Aug 23, 2021
Member
|
I’m assuming the https://github.com/microsoft/TypeScript/pull/45554/files#diff-649a115a1a1a9a6c5eeefa536f5e12d3ef96bfc1c9ea437c42aa28f685ad6960 diff made sense when you viewed it locally; it references DOM types in it so I guess line numbers just changed on super long lines? |
Member
Author
|
Yep, it's just a dump of most of the DOM types, and Window lost its |
Member
Author
|
@typescript-bot cherry-pick this to release-4.4 |
Collaborator
Collaborator
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 23, 2021
Component commits: c9846f8 Restore HTMLDocument constructable value in DOM Don't touch anything else in the DOM.
sandersn
added a commit
that referenced
this pull request
Aug 23, 2021
Component commits: c9846f8 Restore HTMLDocument constructable value in DOM Don't touch anything else in the DOM. Co-authored-by: Nathan Shively-Sanders <[email protected]>
This was referenced Sep 25, 2021
BobobUnicorn
pushed a commit
to BobobUnicorn/TypeScript
that referenced
this pull request
Oct 24, 2021
Don't touch anything else in the DOM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't touch anything else in the DOM. Less consistent with
@types/webthan #45553, but safer to ship late in 4.4's release.