feat(44888): Don't show object property name completions when the originating type is a class with private or protected members #45044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
requested changes
Jul 15, 2021
tests/cases/fourslash/completionInsideObjectLiteralExpressionWithInstantiatedClassType.ts
Outdated
Show resolved
Hide resolved
a-tarasyuk
force-pushed
the
feat/44888
branch
2 times, most recently
from
1581636 to
d98e472
Compare
|
I hope this will be reviewed for version 4.5 (#45418)! |
sandersn
requested changes
Aug 20, 2021
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
This is ready to go except for names.
sandersn
approved these changes
Aug 20, 2021
BobobUnicorn
pushed a commit
to BobobUnicorn/TypeScript
that referenced
this pull request
Oct 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44888