Properly remove generic types that are constrained to 'null | undefined' in getNonNullableType #44219

ahejlsberg · 2021-05-23T01:05:22Z

ahejlsberg · 2021-05-23T01:07:42Z

This is a very safe fix. If possible, we should cherry pick it for 4.3.

DanielRosenwasser · 2021-05-24T20:37:09Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2021-05-24T20:37:12Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 634b01a. You can monitor the build here.

typescript-bot · 2021-05-24T20:37:12Z

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at 634b01a. You can monitor the build here.

typescript-bot · 2021-05-24T20:37:12Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 634b01a. You can monitor the build here.

typescript-bot · 2021-05-24T20:37:12Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 634b01a. You can monitor the build here.

typescript-bot · 2021-05-24T20:37:12Z

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 634b01a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2021-05-24T20:58:43Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/103786/artifacts?artifactName=tgz&fileId=2CB484CD98847912C74630D9090A4ACD9170A4BE670BCDC20897A5466355A81402&fileName=/typescript-4.4.0-insiders.20210524.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2021-05-24T21:30:51Z

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

typescript-bot · 2021-05-24T21:46:02Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..44219

_Metric	_master	₄₄₂₁₉	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{343,846k (± 0.01%)}	_{343,863k (± 0.02%)}	_{+17k (+ 0.00%)}	_343,768k	_344,059k
_{Parse Time}	_{1.80s (± 0.40%)}	_{1.81s (± 0.73%)}	_{+0.01s (+ 0.33%)}	_1.78s	_1.84s
_{Bind Time}	_{0.84s (± 0.84%)}	_{0.84s (± 0.73%)}	_{+0.00s (+ 0.24%)}	_0.83s	_0.85s
_{Check Time}	_{5.22s (± 0.37%)}	_{5.22s (± 0.44%)}	_{+0.00s (+ 0.02%)}	_5.17s	_5.27s
_{Emit Time}	_{5.48s (± 0.56%)}	_{5.49s (± 0.60%)}	_{+0.01s (+ 0.15%)}	_5.40s	_5.55s
_{Total Time}	_{13.34s (± 0.34%)}	_{13.36s (± 0.45%)}	_{+0.02s (+ 0.15%)}	_13.20s	_13.48s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{200,380k (± 0.02%)}	_{200,349k (± 0.02%)}	_{-31k (- 0.02%)}	_200,262k	_200,416k
_{Parse Time}	_{0.78s (± 0.67%)}	_{0.78s (± 0.43%)}	_{+0.00s (+ 0.13%)}	_0.77s	_0.79s
_{Bind Time}	_{0.53s (± 1.14%)}	_{0.54s (± 0.93%)}	_{+0.01s (+ 1.90%)}	_0.52s	_0.54s
_{Check Time}	_{7.54s (± 0.48%)}	_{7.61s (± 0.68%)}	_{+0.07s (+ 0.87%)}	_7.49s	_7.69s
_{Emit Time}	_{2.24s (± 1.36%)}	_{2.23s (± 0.72%)}	_{-0.00s (- 0.22%)}	_2.19s	_2.27s
_{Total Time}	_{11.09s (± 0.50%)}	_{11.16s (± 0.55%)}	_{+0.07s (+ 0.67%)}	_11.00s	_11.27s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{340,397k (± 0.02%)}	_{340,413k (± 0.02%)}	_{+16k (+ 0.00%)}	_340,300k	_340,573k
_{Parse Time}	_{1.45s (± 0.85%)}	_{1.46s (± 1.12%)}	_{+0.01s (+ 0.48%)}	_1.42s	_1.48s
_{Bind Time}	_{0.74s (± 0.78%)}	_{0.74s (± 1.10%)}	_{+0.00s (+ 0.41%)}	_0.73s	_0.76s
_{Check Time}	_{5.36s (± 0.61%)}	_{5.41s (± 0.46%)}	_{+0.05s (+ 0.88%)}	_5.34s	_5.45s
_{Emit Time}	_{2.97s (± 0.77%)}	_{2.97s (± 0.54%)}	_{+0.00s (+ 0.10%)}	_2.94s	_3.01s
_{Total Time}	_{10.51s (± 0.35%)}	_{10.58s (± 0.28%)}	_{+0.06s (+ 0.58%)}	_10.51s	_10.65s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{304,084k (± 0.04%)}	_{304,017k (± 0.03%)}	_{-66k (- 0.02%)}	_303,850k	_304,195k
_{Parse Time}	_{1.18s (± 0.44%)}	_{1.19s (± 0.93%)}	_{+0.01s (+ 0.68%)}	_1.16s	_1.20s
_{Bind Time}	_{0.70s (± 0.79%)}	_{0.71s (± 0.70%)}	_{+0.01s (+ 1.85%)}	_0.70s	_0.72s
_{Check Time}	_{4.87s (± 0.42%)}	_{4.89s (± 0.49%)}	_{+0.02s (+ 0.43%)}	_4.84s	_4.95s
_{Emit Time}	_{3.06s (± 1.05%)}	_{3.13s (± 1.72%)}	_{+0.07s (+ 2.32%)}	_3.03s	_3.26s
_{Total Time}	_{9.81s (± 0.42%)}	_{9.92s (± 0.53%)}	_{+0.12s (+ 1.17%)}	_9.81s	_10.06s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{471,555k (± 0.01%)}	_{471,632k (± 0.02%)}	_{+76k (+ 0.02%)}	_471,471k	_471,758k
_{Parse Time}	_{1.73s (± 0.29%)}	_{1.73s (± 0.61%)}	_{+0.01s (+ 0.41%)}	_1.70s	_1.75s
_{Bind Time}	_{0.66s (± 0.67%)}	_{0.67s (± 0.56%)}	_{+0.00s (+ 0.45%)}	_0.66s	_0.67s
_{Check Time}	_{14.23s (± 0.64%)}	_{14.31s (± 0.53%)}	_{+0.09s (+ 0.61%)}	_14.12s	_14.47s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.62s (± 0.57%)}	_{16.71s (± 0.51%)}	_{+0.09s (+ 0.57%)}	_16.52s	_16.89s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{322,145k (± 0.03%)}	_{322,049k (± 0.08%)}	_{-96k (- 0.03%)}	_321,036k	_322,303k
_{Parse Time}	_{1.77s (± 0.53%)}	_{1.77s (± 0.54%)}	_{+0.00s (+ 0.11%)}	_1.76s	_1.80s
_{Bind Time}	_{0.82s (± 0.60%)}	_{0.83s (± 1.09%)}	_{+0.01s (+ 0.73%)}	_0.82s	_0.85s
_{Check Time}	_{5.07s (± 0.52%)}	_{5.10s (± 0.51%)}	_{+0.03s (+ 0.63%)}	_5.04s	_5.16s
_{Emit Time}	_{5.66s (± 0.43%)}	_{5.70s (± 0.71%)}	_{+0.04s (+ 0.64%)}	_5.61s	_5.77s
_{Total Time}	_{13.32s (± 0.33%)}	_{13.40s (± 0.46%)}	_{+0.08s (+ 0.60%)}	_13.25s	_13.52s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{187,859k (± 0.07%)}	_{187,766k (± 0.07%)}	_{-93k (- 0.05%)}	_187,430k	_187,968k
_{Parse Time}	_{0.76s (± 0.49%)}	_{0.76s (± 0.45%)}	_{-0.00s (- 0.26%)}	_0.76s	_0.77s
_{Bind Time}	_{0.53s (± 0.56%)}	_{0.53s (± 0.84%)}	_{+0.00s (+ 0.76%)}	_0.52s	_0.54s
_{Check Time}	_{7.07s (± 0.49%)}	_{7.08s (± 0.78%)}	_{+0.01s (+ 0.13%)}	_6.96s	_7.19s
_{Emit Time}	_{2.25s (± 0.85%)}	_{2.29s (± 3.08%)}	_{+0.04s (+ 1.78%)}	_2.21s	_2.55s
_{Total Time}	_{10.61s (± 0.31%)}	_{10.66s (± 0.70%)}	_{+0.04s (+ 0.41%)}	_10.50s	_10.82s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{323,442k (± 0.02%)}	_{323,349k (± 0.06%)}	_{-93k (- 0.03%)}	_322,540k	_323,551k
_{Parse Time}	_{1.42s (± 0.78%)}	_{1.42s (± 0.63%)}	_{-0.00s (- 0.14%)}	_1.40s	_1.43s
_{Bind Time}	_{0.72s (± 1.21%)}	_{0.72s (± 0.77%)}	_{0.00s ( 0.00%)}	_0.71s	_0.73s
_{Check Time}	_{5.19s (± 0.38%)}	_{5.22s (± 0.67%)}	_{+0.03s (+ 0.52%)}	_5.15s	_5.32s
_{Emit Time}	_{2.99s (± 0.42%)}	_{3.02s (± 1.25%)}	_{+0.04s (+ 1.17%)}	_2.95s	_3.12s
_{Total Time}	_{10.31s (± 0.38%)}	_{10.37s (± 0.52%)}	_{+0.06s (+ 0.58%)}	_10.28s	_10.50s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{288,535k (± 0.02%)}	_{288,589k (± 0.01%)}	_{+55k (+ 0.02%)}	_288,541k	_288,628k
_{Parse Time}	_{1.19s (± 0.75%)}	_{1.18s (± 0.70%)}	_{-0.00s (- 0.17%)}	_1.17s	_1.21s
_{Bind Time}	_{0.68s (± 0.85%)}	_{0.69s (± 0.69%)}	_{+0.00s (+ 0.59%)}	_0.68s	_0.70s
_{Check Time}	_{4.79s (± 0.76%)}	_{4.79s (± 0.44%)}	_{+0.00s (+ 0.02%)}	_4.74s	_4.85s
_{Emit Time}	_{3.13s (± 0.56%)}	_{3.14s (± 0.97%)}	_{+0.01s (+ 0.26%)}	_3.06s	_3.20s
_{Total Time}	_{9.79s (± 0.52%)}	_{9.80s (± 0.49%)}	_{+0.01s (+ 0.12%)}	_9.70s	_9.91s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{450,090k (± 0.08%)}	_{450,201k (± 0.07%)}	_{+111k (+ 0.02%)}	_448,938k	_450,484k
_{Parse Time}	_{1.71s (± 0.53%)}	_{1.72s (± 0.87%)}	_{+0.01s (+ 0.47%)}	_1.69s	_1.76s
_{Bind Time}	_{0.64s (± 0.74%)}	_{0.64s (± 1.09%)}	_{-0.00s (- 0.31%)}	_0.63s	_0.66s
_{Check Time}	_{12.78s (± 0.73%)}	_{12.76s (± 0.91%)}	_{-0.01s (- 0.11%)}	_12.60s	_13.16s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.13s (± 0.64%)}	_{15.12s (± 0.80%)}	_{-0.01s (- 0.05%)}	_14.96s	_15.54s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{320,874k (± 0.01%)}	_{320,877k (± 0.01%)}	_{+3k (+ 0.00%)}	_320,819k	_320,911k
_{Parse Time}	_{1.80s (± 0.78%)}	_{1.80s (± 0.39%)}	_{+0.00s (+ 0.06%)}	_1.79s	_1.82s
_{Bind Time}	_{0.87s (± 0.67%)}	_{0.87s (± 0.54%)}	_{+0.00s (+ 0.35%)}	_0.86s	_0.88s
_{Check Time}	_{5.12s (± 0.39%)}	_{5.12s (± 0.45%)}	_{+0.00s (+ 0.08%)}	_5.09s	_5.19s
_{Emit Time}	_{5.72s (± 0.54%)}	_{5.72s (± 0.90%)}	_{-0.00s (- 0.02%)}	_5.65s	_5.86s
_{Total Time}	_{13.51s (± 0.33%)}	_{13.52s (± 0.36%)}	_{+0.01s (+ 0.04%)}	_13.41s	_13.62s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{188,507k (± 0.61%)}	_{188,504k (± 0.62%)}	_{-3k (- 0.00%)}	_186,547k	_189,908k
_{Parse Time}	_{0.80s (± 0.56%)}	_{0.80s (± 0.63%)}	_{-0.00s (- 0.38%)}	_0.79s	_0.81s
_{Bind Time}	_{0.55s (± 0.67%)}	_{0.56s (± 0.79%)}	_{+0.01s (+ 1.26%)}	_0.55s	_0.57s
_{Check Time}	_{7.20s (± 0.72%)}	_{7.15s (± 0.52%)}	_{-0.04s (- 0.58%)}	_7.08s	_7.25s
_{Emit Time}	_{2.26s (± 1.11%)}	_{2.27s (± 0.85%)}	_{+0.00s (+ 0.22%)}	_2.24s	_2.33s
_{Total Time}	_{10.81s (± 0.58%)}	_{10.78s (± 0.39%)}	_{-0.04s (- 0.35%)}	_10.70s	_10.87s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{322,487k (± 0.01%)}	_{322,505k (± 0.01%)}	_{+18k (+ 0.01%)}	_322,451k	_322,580k
_{Parse Time}	_{1.48s (± 1.21%)}	_{1.47s (± 0.67%)}	_{-0.01s (- 0.41%)}	_1.46s	_1.50s
_{Bind Time}	_{0.75s (± 0.80%)}	_{0.75s (± 0.78%)}	_{+0.00s (+ 0.13%)}	_0.74s	_0.76s
_{Check Time}	_{5.17s (± 0.47%)}	_{5.19s (± 0.62%)}	_{+0.02s (+ 0.35%)}	_5.14s	_5.29s
_{Emit Time}	_{3.05s (± 0.48%)}	_{3.05s (± 0.63%)}	_{-0.01s (- 0.16%)}	_3.01s	_3.09s
_{Total Time}	_{10.45s (± 0.36%)}	_{10.46s (± 0.50%)}	_{+0.01s (+ 0.08%)}	_10.37s	_10.58s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{287,598k (± 0.00%)}	_{287,603k (± 0.01%)}	_{+5k (+ 0.00%)}	_287,546k	_287,651k
_{Parse Time}	_{1.24s (± 1.29%)}	_{1.25s (± 1.58%)}	_{+0.01s (+ 1.13%)}	_1.22s	_1.32s
_{Bind Time}	_{0.72s (± 0.80%)}	_{0.71s (± 0.31%)}	_{-0.01s (- 1.25%)}	_0.71s	_0.72s
_{Check Time}	_{4.82s (± 0.41%)}	_{4.81s (± 0.58%)}	_{-0.01s (- 0.31%)}	_4.76s	_4.89s
_{Emit Time}	_{3.22s (± 0.60%)}	_{3.21s (± 0.71%)}	_{-0.01s (- 0.37%)}	_3.15s	_3.26s
_{Total Time}	_{10.00s (± 0.24%)}	_{9.98s (± 0.43%)}	_{-0.02s (- 0.20%)}	_9.93s	_10.14s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{448,640k (± 0.01%)}	_{448,619k (± 0.00%)}	_{-21k (- 0.00%)}	_448,565k	_448,672k
_{Parse Time}	_{1.78s (± 0.65%)}	_{1.78s (± 0.81%)}	_{+0.01s (+ 0.34%)}	_1.74s	_1.80s
_{Bind Time}	_{0.69s (± 0.71%)}	_{0.70s (± 0.64%)}	_{+0.00s (+ 0.58%)}	_0.69s	_0.71s
_{Check Time}	_{13.04s (± 0.70%)}	_{13.00s (± 0.51%)}	_{-0.05s (- 0.35%)}	_12.85s	_13.15s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.51s (± 0.61%)}	_{15.48s (± 0.46%)}	_{-0.03s (- 0.22%)}	_15.36s	_15.65s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-206-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₄₂₁₉	₁₀
_Baseline	_master	₁₀

Developer Information:

Download Benchmark

DanielRosenwasser · 2021-05-24T21:56:28Z

@ahejlsberg the Node 10 check time numbers have me a little bit concerned. Any idea what could have caused that?

CC @amcasey

ahejlsberg · 2021-05-24T22:38:00Z

The Node 10 check time numbers have me a little bit concerned. Any idea what could have caused that?

Those deltas are all in the noise. If you don't like them, just run the tests again. 😉

DanielRosenwasser · 2021-05-24T22:52:15Z

@typescript-bot perf test this

typescript-bot · 2021-05-24T22:52:35Z

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 634b01a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2021-05-25T00:10:06Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..44219

_Metric	_master	₄₄₂₁₉	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{343,861k (± 0.01%)}	_{343,944k (± 0.02%)}	_{+83k (+ 0.02%)}	_343,732k	_344,115k
_{Parse Time}	_{1.79s (± 0.56%)}	_{1.80s (± 0.52%)}	_{+0.01s (+ 0.39%)}	_1.78s	_1.82s
_{Bind Time}	_{0.83s (± 0.63%)}	_{0.84s (± 0.60%)}	_{+0.00s (+ 0.48%)}	_0.83s	_0.85s
_{Check Time}	_{5.21s (± 0.36%)}	_{5.21s (± 0.46%)}	_{+0.01s (+ 0.13%)}	_5.17s	_5.28s
_{Emit Time}	_{5.44s (± 0.49%)}	_{5.44s (± 0.57%)}	_{-0.00s (- 0.00%)}	_5.36s	_5.51s
_{Total Time}	_{13.27s (± 0.34%)}	_{13.29s (± 0.26%)}	_{+0.02s (+ 0.13%)}	_13.17s	_13.34s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{200,391k (± 0.03%)}	_{200,371k (± 0.03%)}	_{-20k (- 0.01%)}	_200,212k	_200,529k
_{Parse Time}	_{0.78s (± 0.93%)}	_{0.78s (± 0.83%)}	_{0.00s ( 0.00%)}	_0.77s	_0.80s
_{Bind Time}	_{0.53s (± 1.04%)}	_{0.53s (± 1.69%)}	_{-0.01s (- 1.13%)}	_0.51s	_0.54s
_{Check Time}	_{7.56s (± 0.75%)}	_{7.54s (± 0.65%)}	_{-0.02s (- 0.28%)}	_7.44s	_7.64s
_{Emit Time}	_{2.24s (± 1.93%)}	_{2.24s (± 0.81%)}	_{-0.01s (- 0.22%)}	_2.19s	_2.28s
_{Total Time}	_{11.12s (± 0.63%)}	_{11.09s (± 0.48%)}	_{-0.03s (- 0.28%)}	_10.96s	_11.19s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{340,438k (± 0.02%)}	_{340,392k (± 0.02%)}	_{-46k (- 0.01%)}	_340,275k	_340,514k
_{Parse Time}	_{1.44s (± 1.06%)}	_{1.45s (± 0.70%)}	_{+0.00s (+ 0.28%)}	_1.42s	_1.47s
_{Bind Time}	_{0.74s (± 0.90%)}	_{0.74s (± 0.60%)}	_{-0.00s (- 0.27%)}	_0.73s	_0.75s
_{Check Time}	_{5.35s (± 0.60%)}	_{5.38s (± 0.41%)}	_{+0.02s (+ 0.41%)}	_5.31s	_5.42s
_{Emit Time}	_{2.96s (± 0.81%)}	_{2.94s (± 0.67%)}	_{-0.02s (- 0.57%)}	_2.89s	_2.98s
_{Total Time}	_{10.50s (± 0.29%)}	_{10.50s (± 0.33%)}	_{+0.01s (+ 0.08%)}	_10.43s	_10.58s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{303,947k (± 0.03%)}	_{304,017k (± 0.03%)}	_{+70k (+ 0.02%)}	_303,867k	_304,345k
_{Parse Time}	_{1.18s (± 0.69%)}	_{1.18s (± 0.85%)}	_{+0.01s (+ 0.68%)}	_1.17s	_1.21s
_{Bind Time}	_{0.71s (± 0.71%)}	_{0.70s (± 0.79%)}	_{-0.00s (- 0.43%)}	_0.69s	_0.71s
_{Check Time}	_{4.87s (± 0.61%)}	_{4.89s (± 0.56%)}	_{+0.02s (+ 0.35%)}	_4.83s	_4.94s
_{Emit Time}	_{3.04s (± 1.25%)}	_{3.07s (± 0.62%)}	_{+0.03s (+ 0.95%)}	_3.03s	_3.10s
_{Total Time}	_{9.79s (± 0.65%)}	_{9.85s (± 0.40%)}	_{+0.05s (+ 0.55%)}	_9.74s	_9.92s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{471,565k (± 0.01%)}	_{471,636k (± 0.01%)}	_{+71k (+ 0.02%)}	_471,499k	_471,818k
_{Parse Time}	_{1.74s (± 0.58%)}	_{1.74s (± 0.64%)}	_{0.00s ( 0.00%)}	_1.71s	_1.76s
_{Bind Time}	_{0.66s (± 0.79%)}	_{0.66s (± 0.84%)}	_{+0.00s (+ 0.15%)}	_0.65s	_0.67s
_{Check Time}	_{14.23s (± 0.50%)}	_{14.20s (± 0.50%)}	_{-0.02s (- 0.17%)}	_14.06s	_14.36s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.62s (± 0.45%)}	_{16.60s (± 0.42%)}	_{-0.02s (- 0.15%)}	_16.46s	_16.73s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{322,057k (± 0.02%)}	_{322,114k (± 0.02%)}	_{+57k (+ 0.02%)}	_321,992k	_322,292k
_{Parse Time}	_{1.78s (± 0.49%)}	_{1.77s (± 0.42%)}	_{-0.01s (- 0.56%)}	_1.75s	_1.78s
_{Bind Time}	_{0.82s (± 0.79%)}	_{0.83s (± 0.70%)}	_{+0.00s (+ 0.61%)}	_0.81s	_0.84s
_{Check Time}	_{5.09s (± 0.37%)}	_{5.10s (± 0.45%)}	_{+0.01s (+ 0.24%)}	_5.06s	_5.14s
_{Emit Time}	_{5.66s (± 0.82%)}	_{5.68s (± 0.50%)}	_{+0.02s (+ 0.28%)}	_5.62s	_5.73s
_{Total Time}	_{13.36s (± 0.42%)}	_{13.38s (± 0.39%)}	_{+0.02s (+ 0.17%)}	_13.24s	_13.46s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{187,663k (± 0.12%)}	_{187,786k (± 0.07%)}	_{+123k (+ 0.07%)}	_187,399k	_187,964k
_{Parse Time}	_{0.77s (± 0.84%)}	_{0.77s (± 1.04%)}	_{0.00s ( 0.00%)}	_0.75s	_0.79s
_{Bind Time}	_{0.53s (± 0.69%)}	_{0.53s (± 1.04%)}	_{+0.01s (+ 1.14%)}	_0.52s	_0.54s
_{Check Time}	_{7.00s (± 0.38%)}	_{7.02s (± 0.85%)}	_{+0.02s (+ 0.23%)}	_6.95s	_7.18s
_{Emit Time}	_{2.26s (± 0.82%)}	_{2.24s (± 0.80%)}	_{-0.02s (- 0.89%)}	_2.20s	_2.28s
_{Total Time}	_{10.55s (± 0.31%)}	_{10.55s (± 0.68%)}	_{+0.00s (+ 0.00%)}	_10.47s	_10.75s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{323,464k (± 0.01%)}	_{323,450k (± 0.02%)}	_{-14k (- 0.00%)}	_323,341k	_323,634k
_{Parse Time}	_{1.41s (± 0.53%)}	_{1.40s (± 0.72%)}	_{-0.01s (- 0.43%)}	_1.38s	_1.42s
_{Bind Time}	_{0.71s (± 1.05%)}	_{0.72s (± 0.93%)}	_{+0.00s (+ 0.56%)}	_0.70s	_0.73s
_{Check Time}	_{5.20s (± 0.40%)}	_{5.20s (± 0.57%)}	_{-0.00s (- 0.06%)}	_5.13s	_5.26s
_{Emit Time}	_{2.98s (± 0.50%)}	_{3.00s (± 0.50%)}	_{+0.02s (+ 0.60%)}	_2.96s	_3.03s
_{Total Time}	_{10.30s (± 0.32%)}	_{10.31s (± 0.42%)}	_{+0.01s (+ 0.12%)}	_10.21s	_10.43s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{288,555k (± 0.02%)}	_{288,566k (± 0.02%)}	_{+12k (+ 0.00%)}	_288,471k	_288,672k
_{Parse Time}	_{1.18s (± 0.66%)}	_{1.19s (± 0.62%)}	_{+0.01s (+ 0.93%)}	_1.17s	_1.21s
_{Bind Time}	_{0.69s (± 0.84%)}	_{0.69s (± 1.32%)}	_{+0.00s (+ 0.29%)}	_0.67s	_0.71s
_{Check Time}	_{4.78s (± 0.30%)}	_{4.76s (± 0.44%)}	_{-0.02s (- 0.42%)}	_4.73s	_4.81s
_{Emit Time}	_{3.11s (± 0.56%)}	_{3.11s (± 0.75%)}	_{+0.00s (+ 0.06%)}	_3.05s	_3.16s
_{Total Time}	_{9.75s (± 0.31%)}	_{9.74s (± 0.47%)}	_{-0.00s (- 0.04%)}	_9.63s	_9.84s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{450,297k (± 0.01%)}	_{450,354k (± 0.01%)}	_{+57k (+ 0.01%)}	_450,246k	_450,490k
_{Parse Time}	_{1.71s (± 0.62%)}	_{1.72s (± 0.50%)}	_{+0.01s (+ 0.41%)}	_1.70s	_1.74s
_{Bind Time}	_{0.63s (± 0.57%)}	_{0.64s (± 0.96%)}	_{+0.01s (+ 1.10%)}	_0.63s	_0.65s
_{Check Time}	_{12.72s (± 0.40%)}	_{12.76s (± 0.54%)}	_{+0.04s (+ 0.32%)}	_12.62s	_12.97s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.07s (± 0.40%)}	_{15.12s (± 0.44%)}	_{+0.05s (+ 0.37%)}	_15.00s	_15.33s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{320,822k (± 0.01%)}	_{320,826k (± 0.00%)}	_{+3k (+ 0.00%)}	_320,794k	_320,857k
_{Parse Time}	_{1.79s (± 0.69%)}	_{1.79s (± 0.29%)}	_{+0.00s (+ 0.06%)}	_1.78s	_1.80s
_{Bind Time}	_{0.87s (± 0.55%)}	_{0.87s (± 0.60%)}	_{+0.00s (+ 0.23%)}	_0.86s	_0.88s
_{Check Time}	_{5.10s (± 0.57%)}	_{5.11s (± 0.56%)}	_{+0.01s (+ 0.27%)}	_5.07s	_5.20s
_{Emit Time}	_{5.70s (± 0.61%)}	_{5.69s (± 0.54%)}	_{-0.01s (- 0.18%)}	_5.62s	_5.75s
_{Total Time}	_{13.46s (± 0.43%)}	_{13.46s (± 0.40%)}	_{+0.01s (+ 0.04%)}	_13.37s	_13.62s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{189,743k (± 0.02%)}	_{189,425k (± 0.38%)}	_{-318k (- 0.17%)}	_186,506k	_189,826k
_{Parse Time}	_{0.80s (± 0.83%)}	_{0.80s (± 0.65%)}	_{+0.00s (+ 0.12%)}	_0.79s	_0.82s
_{Bind Time}	_{0.56s (± 0.85%)}	_{0.55s (± 0.67%)}	_{-0.00s (- 0.36%)}	_0.55s	_0.56s
_{Check Time}	_{7.15s (± 0.84%)}	_{7.12s (± 0.34%)}	_{-0.03s (- 0.38%)}	_7.08s	_7.20s
_{Emit Time}	_{2.27s (± 1.04%)}	_{2.26s (± 0.86%)}	_{-0.02s (- 0.70%)}	_2.22s	_2.32s
_{Total Time}	_{10.78s (± 0.66%)}	_{10.74s (± 0.26%)}	_{-0.04s (- 0.35%)}	_10.67s	_10.78s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{322,491k (± 0.01%)}	_{322,482k (± 0.00%)}	_{-9k (- 0.00%)}	_322,464k	_322,528k
_{Parse Time}	_{1.46s (± 0.57%)}	_{1.46s (± 0.73%)}	_{-0.00s (- 0.07%)}	_1.44s	_1.49s
_{Bind Time}	_{0.75s (± 0.91%)}	_{0.75s (± 1.11%)}	_{-0.00s (- 0.13%)}	_0.73s	_0.77s
_{Check Time}	_{5.18s (± 0.60%)}	_{5.16s (± 0.42%)}	_{-0.02s (- 0.35%)}	_5.11s	_5.20s
_{Emit Time}	_{3.06s (± 0.70%)}	_{3.05s (± 0.62%)}	_{-0.01s (- 0.46%)}	_3.01s	_3.09s
_{Total Time}	_{10.45s (± 0.40%)}	_{10.41s (± 0.34%)}	_{-0.03s (- 0.32%)}	_10.32s	_10.51s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{287,590k (± 0.01%)}	_{287,577k (± 0.00%)}	_{-12k (- 0.00%)}	_287,554k	_287,604k
_{Parse Time}	_{1.25s (± 1.74%)}	_{1.24s (± 1.02%)}	_{-0.01s (- 1.20%)}	_1.21s	_1.27s
_{Bind Time}	_{0.71s (± 0.67%)}	_{0.71s (± 0.31%)}	_{-0.00s (- 0.28%)}	_0.71s	_0.72s
_{Check Time}	_{4.80s (± 0.29%)}	_{4.81s (± 0.35%)}	_{+0.01s (+ 0.21%)}	_4.76s	_4.85s
_{Emit Time}	_{3.21s (± 1.02%)}	_{3.22s (± 0.79%)}	_{+0.01s (+ 0.31%)}	_3.17s	_3.29s
_{Total Time}	_{9.97s (± 0.40%)}	_{9.97s (± 0.25%)}	_{+0.00s (+ 0.01%)}	_9.92s	_10.02s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{448,521k (± 0.06%)}	_{448,613k (± 0.00%)}	_{+92k (+ 0.02%)}	_448,576k	_448,655k
_{Parse Time}	_{1.77s (± 0.94%)}	_{1.77s (± 0.56%)}	_{-0.01s (- 0.39%)}	_1.75s	_1.80s
_{Bind Time}	_{0.69s (± 0.75%)}	_{0.69s (± 0.48%)}	_{+0.00s (+ 0.15%)}	_0.68s	_0.70s
_{Check Time}	_{12.97s (± 0.57%)}	_{13.00s (± 0.52%)}	_{+0.03s (+ 0.19%)}	_12.80s	_13.15s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.43s (± 0.53%)}	_{15.46s (± 0.47%)}	_{+0.02s (+ 0.16%)}	_15.26s	_15.63s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-206-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₄₂₁₉	₁₀
_Baseline	_master	₁₀

Developer Information:

Download Benchmark

ahejlsberg · 2021-05-25T00:13:00Z

@DanielRosenwasser There we go, basically no difference!

DanielRosenwasser · 2021-05-25T00:28:29Z

That's amazing! I can't believe you drove down those numbers in just a few hours!

@typescript-bot cherry-pick this to release-4.3 and LKG

typescript-bot · 2021-05-25T00:28:32Z

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.3 on this PR at 634b01a. You can monitor the build here.

typescript-bot · 2021-05-25T00:34:10Z

Hey @DanielRosenwasser, I've opened #44243 for you.

Component commits: 4475012 Improve getNonNullableType function 86f09ae Add tests d45806a More closely match previous behavior 634b01a Add non-strict mode test

…e-4.3 (#44243) * Cherry-pick PR #44219 into release-4.3 Component commits: 4475012 Improve getNonNullableType function 86f09ae Add tests d45806a More closely match previous behavior 634b01a Add non-strict mode test * Update LKG Co-authored-by: Anders Hejlsberg <[email protected]> Co-authored-by: typescript-bot <[email protected]>

ahejlsberg added 2 commits May 22, 2021 17:59

Improve getNonNullableType function

4475012

Add tests

86f09ae

typescript-bot assigned ahejlsberg May 23, 2021

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 23, 2021

ahejlsberg changed the title ~~Properly remove generic types that are constrained to~~ Properly remove generic types that are constrained to 'null | undefined' in getNonNullableType May 23, 2021

ahejlsberg requested review from DanielRosenwasser and RyanCavanaugh May 23, 2021 01:07

ahejlsberg added 2 commits May 23, 2021 17:03

More closely match previous behavior

d45806a

Add non-strict mode test

634b01a

typescript-bot mentioned this pull request May 24, 2021

🤖 User test baselines have changed for fix43425 typescript-bot/TypeScript#185

Open

typescript-bot mentioned this pull request May 25, 2021

🤖 Pick PR #44219 (Properly remove generic types that ...) into release-4.3 #44243

Merged

DanielRosenwasser merged commit 3938958 into master May 25, 2021

DanielRosenwasser deleted the fix43425 branch May 25, 2021 18:40

Properly remove generic types that are constrained to 'null | undefined' in getNonNullableType #44219

Properly remove generic types that are constrained to 'null | undefined' in getNonNullableType #44219

Uh oh!

Conversation

ahejlsberg commented May 23, 2021

Uh oh!

ahejlsberg commented May 23, 2021

Uh oh!

DanielRosenwasser commented May 24, 2021

Uh oh!

typescript-bot commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 24, 2021

Uh oh!

typescript-bot commented May 24, 2021

Uh oh!

DanielRosenwasser commented May 24, 2021

Uh oh!

ahejlsberg commented May 24, 2021

Uh oh!

DanielRosenwasser commented May 24, 2021

Uh oh!

typescript-bot commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 25, 2021

Uh oh!

ahejlsberg commented May 25, 2021

Uh oh!

DanielRosenwasser commented May 25, 2021

Uh oh!

typescript-bot commented May 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 25, 2021

Uh oh!

Uh oh!

typescript-bot commented May 24, 2021 •

edited

Loading

typescript-bot commented May 24, 2021 •

edited

Loading

typescript-bot commented May 24, 2021 •

edited

Loading

typescript-bot commented May 24, 2021 •

edited

Loading

typescript-bot commented May 24, 2021 •

edited

Loading

typescript-bot commented May 24, 2021 •

edited

Loading

typescript-bot commented May 24, 2021 •

edited

Loading

typescript-bot commented May 25, 2021 •

edited

Loading