In bundle declaration emit, refuse to rewrite nonrelative references … #42306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to files outside the common source directory
typescript-bot
added
Author: Team
For Milestone Bug
orta
approved these changes
Jan 13, 2021
Contributor
orta
left a comment
orta
left a comment
There was a problem hiding this comment.
I see, so we give the compiler error rather than get into a bad dts emit state. Works for me.
Member
|
@weswigham is this ready to merge? |
Member
Author
|
Yeah, lemme merge it~ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to files outside the common source directory
Fixes #39547
Taken with a reintroduction of the flag added in this PR (pending bikeshedding of the flag name), this should allow the user in #39547 to not just have less-broken bundled-up declarations (as this PR allows), but entirely functional ones which should be directly consumable by typescript itself.