Do for unions of many empty-object-spreadables what we did for unions of 2 #42233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
approved these changes
Jan 6, 2021
Member
Author
|
@typescript-bot test this |
Collaborator
|
Heya @weswigham, I've started to run the extended test suite on this PR at 35277d9. You can monitor the build here. |
Collaborator
|
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 35277d9. You can monitor the build here. |
Collaborator
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 35277d9. You can monitor the build here. |
Collaborator
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Member
Author
|
Tests all look good, so I'll merge~ |
Zzzen
pushed a commit
to Zzzen/TypeScript
that referenced
this pull request
Jan 16, 2021
… of 2 (microsoft#42233) * Do for unions of many empty-object-spreadables what we did for unions of 2 * Accept baseline
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41386 by broadening our simplification of a spread of
undefined | Ato be the same asPartial<A>to also recognize things likeundefined | false | Aas the same asPartial<A>. Doing this made it obvious that we also needed to fix #41418, thanks to the introduction of more of those spread-synthetic optional properties. So this also contains the fix for that, making this PR require #41921 get merged for it to be reasonable (I have left one failing test which should pass once #41921 is merged).