-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Add reason for a disabled code action #37871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PranavSenthilnathan
merged 12 commits into
microsoft:master
from
PranavSenthilnathan:codeactiondisabledreason
Jun 22, 2020
+378
−94
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bd9f3cf
add reason for a disabled code action
PranavSenthilnathan ecb957d
add addOrRemoveBracesToArrowFunction
PranavSenthilnathan dd17741
use user preferences
PranavSenthilnathan 8684d36
merge
PranavSenthilnathan 93723fb
add error reason
PranavSenthilnathan a57100e
accept baseline changes
PranavSenthilnathan 569c6f8
fix lint rules
PranavSenthilnathan 6b6d970
move messages to diagnosticMessages.json
PranavSenthilnathan 8ae8304
rename 'error' to 'notApplicableReason'
PranavSenthilnathan e86312c
merge
PranavSenthilnathan 7734694
accept baseline change
PranavSenthilnathan cf992ad
address comments
PranavSenthilnathan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the "innermost" error is the only one we care about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this is probably the most relevant since it's lexically closest to problem.