Add test for goto-definition with project references #24867
Conversation
ghost
mentioned this pull request
ghost
force-pushed
the
testGotoDefWithProjectReferences
branch
from
31baae1 to
a57712c
Compare
ghost
force-pushed
the
testGotoDefWithProjectReferences
branch
from
a57712c to
9a6512f
Compare
|
@weswigham The test is still wrong, could you take a look? |
ghost
force-pushed
the
testGotoDefWithProjectReferences
branch
from
d7bbbd0 to
b9ed8d6
Compare
ghost
force-pushed
the
testGotoDefWithProjectReferences
branch
from
b9ed8d6 to
7c17aeb
Compare
|
|
||
| writeDeclarationFiles(aTs, host, session, [ | ||
| // Need to mangle the sourceMappingURL part or it breaks the build | ||
| { name: "/a/bin/a.d.ts.map", text: '{"version":3,"file":"a.d.ts","sourceRoot":"","sources":["../a.ts"],"names":[],"mappings":"AAAA,kCAAsB"}' }, |
There was a problem hiding this comment.
This sourcemap maps position 0 in the .d.ts to 0 in the .ts and 34 in the .d.ts to 22 in the .ts. The start of the declaration is mapped to the start, and the end is mapped to the end, nothing more. We try to map position 24, which is squarely between those, so return the closest available mapping - 22, the end mapping. toFileSpan in the LS then maps that into a 1-based line & column system. The end position is out of bounds, because, ofc, there's no 1-character identifier at the end of the declaration (and we assume that the length of the declaration span is constant when we map it).
ghost
force-pushed
the
testGotoDefWithProjectReferences
branch
from
49d656d to
0dca8f1
Compare
|
@weswigham @mhegazy Good to merge? |
| const navtoResponse = session.executeCommand(navtoRequest).response as protocol.NavtoResponse["body"]; | ||
|
|
||
| assert.deepEqual(navtoResponse, [ | ||
| // TODO: First result should be from a.ts, not a.d.ts |
There was a problem hiding this comment.
This is just a reminder because navTo doesn't apply sourcemaps yet, right?
Discovered #24866.