Skip to content

Conversation

rbuckton
Copy link
Contributor

Minimal implementation of Decorators

@paulvanbrenk
Copy link
Contributor

Can you add testcases for sourcemaps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to limit the number of concepts users have to deal with and keep the decorator only falvor.

@rbuckton
Copy link
Contributor Author

Merged manually into master

@mhegazy mhegazy deleted the decorators_min branch March 25, 2015 19:31
@mhegazy mhegazy mentioned this pull request Mar 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows you to use decorators before the export keyword.

@decorator export default class Foo {}

But if this is the spec we're following, this isn't actually included in the grammar. Only:

export default @decorator class Foo {}

If you can confirm this is a mistake, I'll open an issue and/or PR if you'd like.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subscribers, discussion is being had here wycats/javascript-decorators#7 (comment)

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants