Add textChanges methods to insert nodes at the start of multiline bodies #20445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
requested review from
amcasey
approved these changes
Dec 4, 2017
src/services/textChanges.ts
Outdated
| this.replaceNode(sourceFile, ctr.body, createBlock([newStatement], /*multiLine*/ true), { useNonAdjustedEndPosition: true }); | ||
| } | ||
| else { | ||
| this.insertNodeAfter(sourceFile, getOpenBrace(ctr, sourceFile), newStatement, { suffix: newLineCharacter }); |
There was a problem hiding this comment.
Is this different from inserting it before the first statement?
There was a problem hiding this comment.
If there's no linebreak after the brace, the new statement will appear on the same line?
There was a problem hiding this comment.
Yeah, failed to account for single-line constructors with statements in them. We should probably just make it multiline if it isn't already.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20073
Calling
insertNodeAfterto insert a node after an open brace is hacky anyway and caused problems when there wasn't already a newline after the open brace. This adds newChangeTrackermethods to insert a node at the beginning of a constructor or class.