Skip to content

Conversation

srenault
Copy link

No description provided.

@msftclas
Copy link

Hi @srenault, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@@ -7344,7 +7344,7 @@ interface Event {
}
declare var Event: {
prototype: Event;
new(): Event;
new(type: string): Event;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This constructor throws if no name is provided, so this parameter should be considered required.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 29, 2015

@srenault thanks for the PR. the issue is that this file is actually auto generated from the IE definition files. this makes it easy for us to get an almost accurate DOM definitions without having to update them manually. We plan on updating how the dom typings are generated but for now, we can not make hand edits to this file. If you can log a separate issue, i can get it fixed in our script and update the file.

@srenault
Copy link
Author

Ok, I suspected this. It there anyway in my project to override / add a definition of Event constructor without edit lib.d.ts ?

@mhegazy
Copy link
Contributor

mhegazy commented Jan 29, 2015

I can not think of one. @RyanCavanaugh ideas?

@mhegazy mhegazy closed this Feb 12, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants