Skip to content

Cleanup emit code for comments. #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 28, 2015
Merged

Cleanup emit code for comments. #1777

merged 5 commits into from
Jan 28, 2015

Conversation

CyrusNajmabadi
Copy link
Contributor

This is a more generalized approach that doesn't require so many constructs to explicitly have 'emitLeading/TrailingComments'

DanielRosenwasser
DanielRosenwasser reviewed Jan 23, 2015
View reviewed changes
tests/baselines/reference/sourceMapValidationClasses.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a signal line comment.

CyrusNajmabadi added a commit that referenced this pull request Jan 28, 2015
@CyrusNajmabadi
Merge pull request #1777 from Microsoft/emitCleanup
b3731f1 
Cleanup emit code for comments.
@CyrusNajmabadi CyrusNajmabadi merged commit b3731f1 into master Jan 28, 2015
@CyrusNajmabadi CyrusNajmabadi deleted the emitCleanup branch January 28, 2015 01:20
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @DanielRosenwasser @msftclas