Check and emit fixes for async iteration #15277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Apr 19, 2017
rbuckton
added a commit
to microsoft/tslib
that referenced
this pull request
Apr 19, 2017
mhegazy
approved these changes
Apr 19, 2017
Contributor
Author
|
I will cherry-pick these changes into release-2.3 this evening. |
This was referenced Apr 19, 2017
aluanhaddad
added a commit
to aluanhaddad/tslib
that referenced
this pull request
Aug 19, 2017
* Fix yield in async generator * Update with changes from microsoft/TypeScript#15277 * Updated version to 1.6.1. * Updated README.md to use latest version. * Update async generator helpers to align with #15521 * Update README * Update version to 1.7.0 * Update asyncDelegator for TS15862 * Update package version * update jspm instructions This updates the jspm installation instructions to remove `npm:` registry prefix as it is no longer necessary as the package is now mapped in the jspm registry. Additionally. the example `tsconfig.json` now reflects the path corresponding to the latest package version and uses the lowercase module kind name `"system"` to match the other example and to avoid warnings issued by VS Code when `"System"` is specified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the emit for the
__asyncGeneratorand__asyncDelegatorhelpers to fix issues withyield*delegation in an async generator. The main change involves modifying__asyncDelegatorto use a two-phase approach to iteration:next/throw/returnto__asyncGeneratoras if it were anawaitand switch phase. After awaiting the result,__asyncGeneratorsends it back to the delegator via a call to itsnextmethod.__asyncGeneratoreither as ayieldor areturnand switch phase.This also addresses a bug in the checker and correctly emits
__asyncValuesin some cases where it was missing.This also addresses an issue where a Promise rejection during delegation of an async iterator was not properly handled.
Fixes: #15143, #14725, and #14442
Related: microsoft/tslib#29