-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add ARM64EC runtime test coverage #5831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StephanTLavavej
wants to merge
12
commits into
microsoft:main
Choose a base branch
from
StephanTLavavej:arm64ec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The product code and the test code correctly avoided emitting `__vectorcall` for ARM64EC, but the expected output didn't consider ARM64EC.
…P1614R2_comparisons.
6de6a6d to
1e859ca
Compare
AlexGuteniev
reviewed
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARM64EC
I can't believe it's not x64!
infrastructure
Related to repository automation
test
Related to test code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5815.
-fuse-ld=link, link with/machine:arm64ec.P0811R3_midpoint_lerp.P0811R3_midpoint_lerp#5685Dev09_158457_tr1_mem_fn_calling_conventionsfor ARM64EC.__vectorcallfor ARM64EC:STL/stl/inc/type_traits
Lines 396 to 397 in defc75b
STL/tests/std/tests/Dev09_158457_tr1_mem_fn_calling_conventions/test.cpp
Lines 67 to 68 in defc75b
STL/tests/std/tests/Dev09_158457_tr1_mem_fn_calling_conventions/test.cpp
Lines 118 to 119 in defc75b
<stacktrace>bug.<stacktrace>: ARM64EC isn't working properly #5830P0881R7_stacktraceto a single thread.<stacktrace>takes a lock, which is why this test was spinning up a second thread, but I think this isn't worth it. If we really wanted to stress the lock, it would have to look very different, and we haven't had issues with this (nor is the code rapidly churning). With @AlexGuteniev's blessing I'm changing this to be single-threaded./OPT:REF,NOICFtouniversal_prefix.lst, fixingP0896R4_P1614R2_comparisons.printf-instrumenting this test, I found that the issue was attempting to verify that&f1and&f2(the addresses of empty functions) were non-equal, and these functions were getting ICFed for ARM64EC:STL/tests/std/tests/P0896R4_P1614R2_comparisons/test.cpp
Lines 397 to 398 in defc75b
STL/tests/std/tests/P0896R4_P1614R2_comparisons/test.cpp
Line 479 in defc75b
/OPT:ICFis enabled by the linker unless/OPT:NOICFor/DEBUGis specified."/OPT:REF,NOICFis what we use for debug builds of the product itself. There's no reason to emit test executables that are more bloated than necessary (REFshould be very cheap in terms of CPU time, and possibly even saving I/O time). We never wantICFfor test executables, as it impacts correctness in this corner case./analyzefor the STL's own sources and no benchmarks).