Updated radial and checkBox themes #3279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the unselected state.
…trols sense it does not animate from activated to non activated. Finished a feature I started implimenting a while ago to remove the easing controls when a theme property does not require animation, like strings and audio clips. We could add themes later to fade audio or animate strings.
keveleigh
reviewed
Dec 18, 2018
Assets/MixedRealityToolkit-SDK/Inspectors/UX/Interactable/ThemeInspector.cs
Outdated
Show resolved
Hide resolved
Assets/MixedRealityToolkit-SDK/Inspectors/UX/Interactable/ThemeInspector.cs
Outdated
Show resolved
Hide resolved
Assets/MixedRealityToolkit-SDK/Inspectors/UX/Interactable/ThemeInspector.cs
Outdated
Show resolved
Hide resolved
Assets/MixedRealityToolkit-SDK/Inspectors/UX/Interactable/ThemeInspector.cs
Outdated
Show resolved
Hide resolved
keveleigh
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A bug on the radials and checkbox controls was pointed out last week. The dots and checks should only appear during the selected states. Updated the new theme to turn the dots and checks off.
Looked at why the animation does not happen on the first click of a toggle button, but each future click themes animated correctly.
Fixed an issue with the InteractableActivatorTheme. It should not have easing controls sense it does not animate from activated to non activated. Finished a feature I started implimenting a while ago to remove the easing controls when a theme property does not require animation, like strings and audio clips. We could add themes later to fade audio or animate strings.
Radial and check box toggles did not visually update correctly for each selected state (show and hide dot or check) .
When a button moved to the selected state, like the toggle, the dot jumped to the other side instead of animated.
Theme that do not support easing still showed easing controls.