Skip to content

Mouse Input Fixes #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 30, 2018
Merged

Mouse Input Fixes #3003

merged 13 commits into from
Oct 30, 2018

Conversation

@StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Oct 28, 2018 •
edited
Loading

Overview

  • Fixed issues with Mouse in OpenVR
  • Cleaned up a few input related classes with simpler logic.
  • Added configurable mouse pointer properties
    image
    • Hide mouse cursor on start.
    • Hide mouse after a few seconds if no input is detected from it.
    • Show mouse if any button is pressed / or above a set threshold.
      • When mouse is shown it's position is at gaze position
      • Mouse click to un-hide doesn't raise pointer click.

Changes

@StephenHodgson StephenHodgson added this to the MRTK 2018 milestone Oct 28, 2018
@StephenHodgson StephenHodgson mentioned this pull request Oct 29, 2018
Closed
32 tasks
@SimonDarksideJ
Copy link
Contributor

SimonDarksideJ commented Oct 29, 2018

Can we have a demo scene showing mouse input over controllers? if it's not too much trouble.

@StephenHodgson
Copy link
Contributor Author

StephenHodgson commented Oct 29, 2018

You could use it any any scene, just like any other controller. We don't have demo scenes for any of our other controllers, should we also add that as well in a subsequent PR?

SimonDarksideJ
SimonDarksideJ previously approved these changes Oct 29, 2018
View reviewed changes
@SimonDarksideJ SimonDarksideJ changed the base branch from mrtk_development to mrtk_2018beta_stabilization October 29, 2018 19:26
david-c-kline
david-c-kline reviewed Oct 29, 2018
View reviewed changes
Copy link

@david-c-kline david-c-kline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a demo scene that shows using the mouse pointer script?

@david-c-kline
Copy link

david-c-kline commented Oct 29, 2018

That pointer settings script has some great looking features that would be nice to demo.

@StephenHodgson
Copy link
Contributor Author

StephenHodgson commented Oct 29, 2018

Every scene is a demo scene. We don't have demo scenes for the controllers.

@StephenHodgson
Copy link
Contributor Author

StephenHodgson commented Oct 29, 2018

Should we also add demo scenes for motion controllers as well?

@david-c-kline
Copy link

david-c-kline commented Oct 29, 2018

Every scene is a demo scene. We don't have demo scenes for the controllers.

We also don't have the threshold settings that make this a very compelling feature

@david-c-kline
Copy link

david-c-kline commented Oct 29, 2018

Should we also add demo scenes for motion controllers as well?

Maybe, but this mouse script has some great customer focused settings that would be really nice to enable easy experimentation.

@StephenHodgson
Copy link
Contributor Author

StephenHodgson commented Oct 29, 2018

Now that I think about it, I need to do more work to this PR by supporting an "always on" setting, in case someone wants that.

@david-c-kline
Copy link

david-c-kline commented Oct 29, 2018

Question: Is the intent to have the vertical axes inverted? I was initially puzzled as to why pulling back on the mouse moved the cursor up in the world.

@StephenHodgson
Copy link
Contributor Author

StephenHodgson commented Oct 29, 2018

Question: Is the intent to have the vertical axes inverted? I was initially puzzled as to why pulling back on the mouse moved the cursor up in the world.

Should also probably be customizable as well. I'll add that as well

@david-c-kline
Copy link

david-c-kline commented Oct 29, 2018

I'll wait for your update and then test again.

@StephenHodgson
Copy link
Contributor Author

StephenHodgson commented Oct 29, 2018

Likely we want to be able to let users invert the mouse at the Controller mapping profile. Gotta think about this one a tick.

@StephenHodgson StephenHodgson dismissed SimonDarksideJ’s stale review October 29, 2018 21:22

need to address feedback.

@david-c-kline
Copy link

david-c-kline commented Oct 29, 2018

Likely we want to be able to let users invert the mouse at the Controller mapping profile. Gotta think about this one a tick.

Should the default be forward == up? It feels like it.

@StephenHodgson
Copy link
Contributor Author

StephenHodgson commented Oct 29, 2018

Should the default be forward == up? It feels like it.

Probably. Sounds correct to me.

@StephenHodgson
Copy link
Contributor Author

StephenHodgson commented Oct 29, 2018

I was initially puzzled as to why pulling back on the mouse moved the cursor up in the world.

When pushing the mouse up on the pad, the mouse should rise in front of your view as well. (Just like what you'd expect to see on screen).

The axis inversion might need to be a separate PR as it needs to be changed in the Controller Mapping Profile

@StephenHodgson
Fixed mouse resetting after timer wind down even though it was still …
eda4221 
…enabled.

Made sure that disabling the "Hide Cursor when active" flag didn't hide it after timer winddown
Consolidated some duplicated code.
Updated inspector.
@StephenHodgson
Merge branch 'mrtk_2018beta_stabilization' into vNEXT-OpenVR-MouseInp…
5d5e8e9 
…utFixes

# Conflicts:
#	Assets/MixedRealityToolkit-SDK/Profiles/DefaultMixedRealityRegisteredServiceProvidersProfile.asset
@StephenHodgson
added mouse input manager back in registered service provider list
4dfbeb7
@StephenHodgson
revert
9f354b3
SimonDarksideJ
SimonDarksideJ approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @davidkline-ms can you also test and approve?

@david-c-kline
Copy link

david-c-kline commented Oct 30, 2018

Looks good to me. @davidkline-ms can you also test and approve?

Will do.

@david-c-kline
Copy link

david-c-kline commented Oct 30, 2018

I am getting some odd feeling behaviors, though that might be my inexperience with the feature. The concerns I had with the previous version of this PR have been addressed.

@david-c-kline david-c-kline merged commit a20158f into microsoft:mrtk_2018beta_stabilization Oct 30, 2018
@StephenHodgson StephenHodgson deleted the vNEXT-OpenVR-MouseInputFixes branch October 30, 2018 19:45
@Alexees
Copy link
Contributor

Alexees commented Feb 8, 2019 •
edited
Loading

@StephenHodgson Just wanted to use an eventdata's Pointer.TryGetPointerPosition for the mousecursor, but it seems it's returned to something's localspace as it's definitely not world space. Is it the camera I have to transform it from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@SimonDarksideJ SimonDarksideJ SimonDarksideJ approved these changes

@david-c-kline david-c-kline david-c-kline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Input System - General

Projects

None yet

Milestone

Mixed Reality Toolkit v2

Development

Successfully merging this pull request may close these issues.

4 participants

@StephenHodgson @SimonDarksideJ @david-c-kline @Alexees