Fixed UWP Lag issue, changed from Event Based updates to polling. #2890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue seems related to the way Unity is exposing the InteractionManager and access to the data within which seems UI / polling bound.
SimonDarksideJ
requested review from
StephenHodgson,
david-c-kline and
keveleigh
StephenHodgson
approved these changes
Oct 7, 2018
david-c-kline
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue seems related to the way Unity is exposing the InteractionManager and access to the data within which seems UI / polling bound (only works correctly when attached to a GameObject/MonoBehaviour).
The resolution was to change from using the InteractionManager events for update / pressed / released, to polling during the Unity Update event. This ensures the data is synchronised accurately.
Changes
Results
From (Top - Raw, Bottom - MRTK)
To (Top - Raw, Middle - MRTK, Bottom - InteractionDef)
