Skip to content

Conversation

bjcmit
Copy link
Contributor

@bjcmit bjcmit commented Feb 8, 2020

  • Fixed test_train_model test in code_test.py
  • Renamed code_test.py to train_test.py
  • Moved train_test.py under diabetes_regression directory
  • Moved data_test.py under data directory
  • Added lint and unit test tasks to azdo-base-pipeline.yml
  • Deleted lint-and-test.sh and tox.ini

- Renamed code_test.py to train_test.py
- Moved train_test.py under diabetes_regression directory
- Moved data_test.py under data directory
- Added lint and unit test tasks to azdo-base-pipeline.yml
- Deleted lint-and-test.sh and tox.ini
@bjcmit bjcmit changed the title - Fixed test_train_model test in code_test.py Fixed and rearranged unit tests Feb 8, 2020
@bjcmit bjcmit requested a review from dtzar February 8, 2020 00:13
Copy link
Contributor

@dtzar dtzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudivate
Copy link
Contributor

@bjcmit now that you have moved the test files to the respective project directory. Would you like to consider deleting the folder at the root?

@dtzar
Copy link
Contributor

dtzar commented Feb 10, 2020

Build fails lint ./diabetes_regression/training/test_train.py:27:73: W292 no newline at end of file

@dtzar
Copy link
Contributor

dtzar commented Feb 10, 2020

@bjcmit now that you have moved the test files to the respective project directory. Would you like to consider deleting the folder at the root?

Yes, we should remove that root test/unit directory. I believe if you delete init.py there it should go away.

@bjcmit bjcmit merged commit 6efc12c into master Feb 10, 2020
@dtzar dtzar deleted the brysmith/fix_test_train_model branch February 10, 2020 21:31
@dtzar dtzar mentioned this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants