Skip to content

ActivityType POC (v2) #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

ActivityType POC (v2) #493

wants to merge 3 commits into from

Conversation

@tracyboehrer
Copy link
Member

@tracyboehrer tracyboehrer commented Oct 27, 2025 •
edited
Loading

  • Adds ActivityType class
  • Backward compatible with existing ActivityTypes
  • Most of the changes are because the original ActivityTypes is obsoleted and required changes all over to stop using.
  • Allows for a more discoverable list:
    {BC432065-4C0A-4CA0-AFC6-20FFFF7206DB}
  • More natural comparisons: if (activity.Type == ActivityType.Message)
  • Still allows for custom Activity Types
  • Enforces casing for serialize/deserialize for consistency
  • Can be used where constants are required (Attributes, switch statements, etc...)
  • This isn't an enum, but has some of the same benefits.
  • Drawbacks
    • ActivityType.Equals does a case-insensitive compare
      • activity.Type == ActivityType.Message and activity.Type == "mEsSaGe" are both true
      • But the reverse is not true since it uses string.Equals: "mEsSaGe" == activity.Type is false.

Tracy Boehrer added 3 commits August 11, 2025 07:44
Initial ActivityType class (fake enum)
8fadcd1
ActivityType class with inner string. Support cases where a const val…
bcb2317 
…ue is required.
Merge branch 'main' into users/tracyboehrer/activity-type-enumish
e6ec6d4 
# Conflicts:
#	src/libraries/Builder/Microsoft.Agents.Builder/App/AgentApplication.cs
#	src/libraries/Builder/Microsoft.Agents.Builder/TranscriptLoggerMiddleware.cs
#	src/libraries/Extensions/Microsoft.Agents.Extensions.Teams/App/TeamsAgentExtension.cs
#	src/libraries/Storage/Microsoft.Agents.Storage.Transcript/FileTranscriptLogger.cs
#	src/tests/Microsoft.Agents.Builder.Tests/App/ApplicationRouteTests.cs
@github-actions github-actions bot added ML: Samples Tags changes to samples ML: Core Tags changes to core libraries ML: Tests Tags changes to tests labels Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ML: Core Tags changes to core libraries ML: Samples Tags changes to samples ML: Tests Tags changes to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tracyboehrer