Skip to content

Add analyzers and remove manual assembly attribute #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add analyzers and remove manual assembly attribute #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d8fade2
Add analyzers and remove manual assembly attribute
olstakh Sep 20, 2025
013e07f
Lower code analysis package version to cover more consumers
olstakh Sep 20, 2025
7a11718
Downgrade to lowest possible version
olstakh Sep 21, 2025
95122d7
Merge branch 'main' into users/olstakh/use-analyzer
tracyboehrer Sep 22, 2025
3170756
Merge branch 'main' into users/olstakh/use-analyzer
tracyboehrer Sep 23, 2025
1062cb6
Merge branch 'main' into users/olstakh/use-analyzer
tracyboehrer Sep 30, 2025
b44def5
Merge branch 'main' of https://github.com/microsoft/Agents-for-net in…
olstakh Sep 30, 2025
b6a8d77
Post merge
olstakh Sep 30, 2025
f78593b
Merge branch 'main' into users/olstakh/use-analyzer
tracyboehrer Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageVersion>
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.1" />
<PackageVersion Include="PolySharp" Version="1.15.0" />
<PackageVersion Include="CsvHelper" Version="33.0.1" />
<PackageVersion Include="Microsoft.Extensions.AI.OpenAI" Version="9.1.0-preview.1.25064.3" />
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Core/Microsoft.Agents.Core/Microsoft.Agents.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
In order for packing targets to work correctly in this situation - analyzer project either should have <TargetFramework> (without 's'),
or be referenced with Condition on a single TargetFramework.
-->
<ProjectReference Include="..\Microsoft.Agents.Core.Analyzers\Microsoft.Agents.Core.Analyzers.csproj" ReferenceOutputAssembly="false" Condition="'$(TargetFramework)' == 'netstandard2.0'" />
<ProjectReference Include="..\Microsoft.Agents.Core.Analyzers\Microsoft.Agents.Core.Analyzers.csproj" ReferenceOutputAssembly="false" Condition="'$(TargetFramework)' == 'netstandard2.0'" PrivateAssets="all" />
</ItemGroup>

</Project>
1 change: 0 additions & 1 deletion src/libraries/Extensions/Microsoft.Agents.Extensions.SharePoint/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion ...ions/Microsoft.Agents.Extensions.SharePoint/Microsoft.Agents.Extensions.SharePoint.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
<PackageId>Microsoft.Agents.Extensions.SharePoint</PackageId>
<Description>Library for creating SharePoint agents using Microsoft Agent SDK</Description>
<Summary>Library for building SharePoint agents using Microsoft Agents SDK</Summary>
</PropertyGroup>
<!-- Set to true to see generated file in obj/Debug/.../Generated folder -->
<EmitCompilerGeneratedFiles>false</EmitCompilerGeneratedFiles>
</PropertyGroup>

<PropertyGroup>
<Nullable>annotations</Nullable>
Expand All @@ -32,6 +34,7 @@
<ItemGroup>
<ProjectReference Include="..\..\Builder\Microsoft.Agents.Builder\Microsoft.Agents.Builder.csproj" />
<ProjectReference Include="..\..\Core\Microsoft.Agents.Core\Microsoft.Agents.Core.csproj" />
<ProjectReference Include="..\..\Core\Microsoft.Agents.Core.Analyzers\Microsoft.Agents.Core.Analyzers.csproj" ReferenceOutputAssembly="false" OutputItemType="Analyzer" PrivateAssets="all" />
</ItemGroup>

</Project>
1 change: 0 additions & 1 deletion src/libraries/Extensions/Microsoft.Agents.Extensions.Teams/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@
// Allows us to access some internal methods from the Memory.Tests unit tests so we don't have to use reflection and we get compile checks.
[assembly: InternalsVisibleTo("Microsoft.Agents.Connector.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: InternalsVisibleTo("Microsoft.Agents.Extensions.Teams.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: Microsoft.Agents.Core.Serialization.SerializationInitAssembly(typeof(Microsoft.Agents.Extensions.Teams.Serialization.SerializationInit))]
3 changes: 3 additions & 0 deletions ...ies/Extensions/Microsoft.Agents.Extensions.Teams/Microsoft.Agents.Extensions.Teams.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
<ComponentAreaName>CplTeams</ComponentAreaName>
<SignAssembly>true</SignAssembly>
<PackageReadmeFile>README.md</PackageReadmeFile>
<!-- Set to true to see generated file in obj/Debug/.../Generated folder -->
<EmitCompilerGeneratedFiles>false</EmitCompilerGeneratedFiles>
</PropertyGroup>
<Import Project="..\..\..\Build.Common.core.props" />

Expand Down Expand Up @@ -33,6 +35,7 @@
<ProjectReference Include="..\..\Builder\Microsoft.Agents.Builder\Microsoft.Agents.Builder.csproj" />
<ProjectReference Include="..\..\Client\Microsoft.Agents.Connector\Microsoft.Agents.Connector.csproj" />
<ProjectReference Include="..\..\Core\Microsoft.Agents.Core\Microsoft.Agents.Core.csproj" />
<ProjectReference Include="..\..\Core\Microsoft.Agents.Core.Analyzers\Microsoft.Agents.Core.Analyzers.csproj" ReferenceOutputAssembly="false" OutputItemType="Analyzer" PrivateAssets="all" />
</ItemGroup>

</Project>
Loading