New transition animation shows duplicate image during transition

[ericpapamarcos]

Thanks for this excellent library!

I noticed that #104 changed the transition animation.

This screen grab (from iOS 14) shows the transition from your example app after clicking on the cat in the top left corner:

The updated transition appears to simultaneously fade out the original image, translate the original image to its new location, and also fade in a second image at the new location in the middle of the screen. The end result is that two images appear on screen during the transition which appears a little glitchy compared to the previous experience.

I've also noticed an issue where the image completely disappears during the transition where the original image fades out, but the second image doesn't fade in.

Can you please fix the transition to not duplicate the image?

[michaelhenry]

@ericpapamarcos thanks for the report. I will look into it.

[michaelhenry]

@ericpapamarcos please check v3.3.3 thanks

[ericpapamarcos]

This fixes the animation issue!

However, I'm still consistently seeing the new issue where the image completely disappears after the transition is complete. I've tried both .theme(.light) and .theme(.dark) and the issue repros consistently for both modes. (The issue repros consistently on device for me, but less so in the simulator.)

Is the code setting the opacity back to 0 when it's finished animating in some case?

[michaelhenry]

@ericpapamarcos i will check it. Thanks

[github-actions]

Stale issue message