Skip to content
This repository was archived by the owner on Oct 24, 2021. It is now read-only.

Conversation

@realyze
Copy link

@realyze realyze commented Jul 19, 2021

I just got bitten by rate-limiter thinking by default the rule applies to each connection separately. This example should help educate users that it is not in fact the case unless you add connectionId() { return true; }.

I just got bitten by rate-limiter thinking by default the rule applies to each connection separately. This example should help educate users that it is not in fact the case unless you add `connectionId() { return true; }`.
@StorytellerCZ
Copy link
Collaborator

Hi @realyze !
Thanks for the submission! Could you maybe add comment into the connectionId function that explains why that part is required or at least highlights that it is required so that people don't throw it out by accident?

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants