Skip to content

Make language and refrence marker configurable #657 #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 31, 2025
Merged

Make language and refrence marker configurable #657 #658

merged 8 commits into from
Jan 31, 2025

Conversation

@TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Jan 30, 2025 •
edited
Loading

Not sure if i need to add tests. See #657

@TobiasNx TobiasNx requested a review from dr0i January 30, 2025 12:54
blackwinter
blackwinter requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: refrence -> reference

@TobiasNx TobiasNx removed their assignment Jan 30, 2025
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Jan 30, 2025

I tried to test it with: rdf-macros(referenceMarker="#")| here metafacture-runner/src/main/dist/examples/marc21-to-edm/MARC21-EDM.flux

but i get an error:

$ '/home/tobias/git/metafacture-core/metafacture-runner/build/install/metafacture-core/flux.sh' '/home/tobias/git/metafacture-core/metafacture-runner/src/main/dist/examples/marc21-to-edm/MARC21-EDM.flux'
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/tobias/git/metafacture-core/metafacture-runner/build/install/metafacture-core/lib/slf4j-simple-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/tobias/git/metafacture-core/metafacture-runner/build/install/metafacture-core/lib/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.SimpleLoggerFactory]
Exception in thread "main" org.metafacture.commons.reflection.ReflectionException: Method RdfMacroPipe.referencemarker does not exist
        at org.metafacture.commons.reflection.ConfigurableClass.applySetters(ConfigurableClass.java:186)
        at org.metafacture.commons.reflection.ConfigurableClass.newInstance(ConfigurableClass.java:145)
        at org.metafacture.commons.reflection.ObjectFactory.newInstance(ObjectFactory.java:105)
        at org.metafacture.flux.parser.FluxProgramm.createElement(FluxProgramm.java:78)
        at org.metafacture.flux.parser.FluxProgramm.addElement(FluxProgramm.java:90)
        at org.metafacture.flux.parser.FlowBuilder.pipe(FlowBuilder.java:736)
        at org.metafacture.flux.parser.FlowBuilder.flowtail(FlowBuilder.java:514)
        at org.metafacture.flux.parser.FlowBuilder.flow(FlowBuilder.java:226)
        at org.metafacture.flux.parser.FlowBuilder.flux(FlowBuilder.java:122)
        at org.metafacture.flux.FluxCompiler.compileFlow(FluxCompiler.java:66)
        at org.metafacture.flux.FluxCompiler.compile(FluxCompiler.java:54)
        at org.metafacture.runner.Flux.main(Flux.java:87)

@blackwinter
Copy link
Member

blackwinter commented Jan 30, 2025

Setter for char is not an eligible type, use String with .charAt(0) instead.

@TobiasNx
Copy link
Contributor Author

TobiasNx commented Jan 30, 2025

Setter for char is not an eligible type, use String with .charAt(0) instead.

Thanks did that! Thanks! Also thanks to @dr0i

@metafacture metafacture deleted a comment from TobiasNx Jan 30, 2025
@metafacture metafacture deleted a comment from TobiasNx Jan 30, 2025
dr0i
dr0i requested changes Jan 30, 2025
View reviewed changes
@TobiasNx TobiasNx requested review from blackwinter and dr0i January 30, 2025 16:00
blackwinter
blackwinter approved these changes Jan 30, 2025
View reviewed changes
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Jan 31, 2025

@dr0i could you review it again?

@dr0i dr0i assigned TobiasNx and unassigned dr0i Jan 31, 2025
@TobiasNx TobiasNx merged commit 16a41b0 into master Jan 31, 2025
1 check passed
@TobiasNx TobiasNx mentioned this pull request Feb 3, 2025
Closed
@blackwinter blackwinter deleted the 657-rdf-marker-configurator branch February 14, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blackwinter blackwinter blackwinter approved these changes

@dr0i dr0i dr0i approved these changes

Assignees

@TobiasNx TobiasNx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TobiasNx @blackwinter @dr0i