Skip to content

Update dependencies #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2023
Merged

Update dependencies #489

merged 3 commits into from
Jun 6, 2023

Conversation

@dr0i
Copy link
Member

@dr0i dr0i commented Jun 5, 2023 •
edited
Loading

This updates dependencies which don't need code rework and introduces some version variables for easier maintaining.

See #487.

@dr0i
Update dependencies (#487)
5b9b918 
- update dependencies which don't need code rework
- introduce some version variables for easier maintaining
@dr0i dr0i closed this Jun 5, 2023
@dr0i dr0i reopened this Jun 5, 2023
@dr0i dr0i marked this pull request as draft June 5, 2023 15:50
@dr0i dr0i mentioned this pull request Jun 5, 2023
Closed
8 tasks
@dr0i dr0i marked this pull request as ready for review June 6, 2023 07:30
@dr0i dr0i requested review from blackwinter and fsteeg and removed request for fsteeg June 6, 2023 07:30
@dr0i
Copy link
Member Author

dr0i commented Jun 6, 2023 •
edited
Loading

Based on this PR is the sonatype SNAPSHOT release 5.6.0-rc1-SNAPSHOT. See wiki/Maintainer-Guideline how to use it. Please test it and check mark:

  • lobid-resources
  • limetrans
  • fix
  • playground

@dr0i dr0i requested a review from katauber June 6, 2023 07:35
blackwinter
blackwinter requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some dependency introductions/type changes are unclear to me.

@dr0i dr0i marked this pull request as draft June 6, 2023 08:49
@dr0i
Correct update of dependencies (#489)
8ec34cc 
- don't align values
- remove superflous slf4j-api
- reset to testRuntimeOnly

Complements 5b9b918.
@dr0i dr0i requested a review from blackwinter June 6, 2023 09:04
@dr0i dr0i marked this pull request as ready for review June 6, 2023 09:14
@dr0i dr0i merged commit 2cec789 into master Jun 6, 2023
@dr0i dr0i deleted the 5.6.0-rc1 branch June 6, 2023 11:43
@dr0i dr0i mentioned this pull request Nov 17, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blackwinter blackwinter blackwinter approved these changes

@fsteeg fsteeg fsteeg approved these changes

@katauber katauber Awaiting requested review from katauber

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dr0i @blackwinter @fsteeg