Don't allow unused **kwargs in input_constructors except for a defined set of exceptions #1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jun 7, 2023
…d set of exceptions (meta-pytorch#1872) Summary: Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: ab1a956e509432a3a2ae7d662b5d7c5f7881c3aa
esantorella
force-pushed
the
export-D46519588
branch
from
c0e0a63 to
1fc3457
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jun 7, 2023
…d set of exceptions (meta-pytorch#1872) Summary: Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 81049c245489ceb6379a12a7e6d5ca9a6cd74898
esantorella
force-pushed
the
export-D46519588
branch
from
1fc3457 to
d139a84
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jun 7, 2023
…d set of exceptions (meta-pytorch#1872) Summary: Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: a06f96922f15d69ca3e48f62db09454352d45de2
esantorella
force-pushed
the
export-D46519588
branch
from
d139a84 to
d5bd92a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
Codecov Report
@@ Coverage Diff @@
## main #1872 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 178 178
Lines 15721 15725 +4
=========================================
+ Hits 15721 15725 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jun 7, 2023
…d set of exceptions (meta-pytorch#1872) Summary: Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 737244239843e4c512e81bbd3c8b682b8ba93bb0
esantorella
force-pushed
the
export-D46519588
branch
from
d5bd92a to
d3a0d1e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 9, 2023
…d set of exceptions (meta-pytorch#1872) Summary: Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 8fb2024144b10f683f7062604de879caba27aba3
esantorella
force-pushed
the
export-D46519588
branch
from
d3a0d1e to
62071c2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 9, 2023
…d set of exceptions Summary: X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: c260276514e97c093d01255b9c8e6a7aa7142b06
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 9, 2023
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 62bdc6d4d998d5d0f483210889750de00114fbe6
esantorella
force-pushed
the
export-D46519588
branch
from
62071c2 to
b6c07c0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 9, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 4407a32b94ff51db28e2b625188eea2fd89c1e71
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 9, 2023
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 9120903061b156639395883090919cab2da1bced
esantorella
force-pushed
the
export-D46519588
branch
from
b6c07c0 to
ff58340
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 9, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 44c5c6e99a4e3ae3b287da9901a9e20af322239e
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 11, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: SebastianAment Differential Revision: D46519588 fbshipit-source-id: 44ea95d82cd50a3ecebc248759ea5d1db9a3bf51
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 74049ac702fbe77ab50e5e7434bc0a6979f8a5e4
esantorella
force-pushed
the
export-D46519588
branch
from
dfbe9c4 to
5437f17
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 2870b074becf102f712a3380b316dfe037cd9bdc
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 325e41bb0e2b2be501403fdb039d22f3ef91e11b
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 15e0249c1d6e06f57b24926969b8859e071efe14
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 8b6dfddd8044eb14f6b06dc09d039ddfb4282380
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 16, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 39c46dbc04c5464d7bb7b2720e91bfca92156c55
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 47d734acb908c2af72b8729a9325befeb0575074
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: c267fc464e0f3dd1d221f3ae13f74c0eb8c7a81f
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: ef78006e43f2aca6ec94f1bb0126a8842a945345
esantorella
force-pushed
the
export-D46519588
branch
from
5437f17 to
0dc36c9
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: ebd0acf14dd96e11c87ed85b3fa1963c26f70823
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 383954715df45538fda470ecdeb5acdcc9171d18
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 5b295423e549939117fce25547612e48f38c49f3
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: 986c242587b418a083dc58360622ddb4cc2842bb
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 9396e0c72f235a7adc693c5539a4cd8447943e86
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 862fab3fca2460e04462b4b408b6bc3431baa0ff
esantorella
force-pushed
the
export-D46519588
branch
from
0dc36c9 to
0425d46
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Differential Revision: https://internalfb.com/D46519588 fbshipit-source-id: a8e6c319bd706d532b6d822255f85f9247e0402e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (facebook#1772) Summary: Pull Request resolved: facebook#1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 7a050d71f8a2a9bf75a34dd7fa69c1481d049fe4
…d set of exceptions (meta-pytorch#1872) Summary: X-link: facebook/Ax#1772 Pull Request resolved: meta-pytorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 5be2e27d8ccd5f01edef468da10133cfe1f8e03e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46519588 |
esantorella
force-pushed
the
export-D46519588
branch
from
0425d46 to
5600900
Compare
Contributor
|
This pull request has been merged in b6e74ac. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Aug 17, 2023
…d set of exceptions (#1772) Summary: Pull Request resolved: #1772 X-link: meta-pytorch/botorch#1872 [x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into `**kwargs` and be silently ignored [x] add arguments to some input constructors so they don't need any `**kwargs` [x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on [ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions Reviewed By: lena-kashtelyan Differential Revision: D46519588 fbshipit-source-id: 8d727cb991f2899cc9e7ee68da7998e981ca8802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[x] Remove unused arguments from input constructors and related functions. The idea is especially not to let unused keyword arguments disappear into
**kwargsand be silently ignored[x] add arguments to some input constructors so they don't need any
**kwargs[x] Add a decorator that ensures that each input constructor can accept a certain set of keyword arguments, even if those are not used are the constructor, while still erroring on
[ ] Prevent arguments from having different defaults in the input constructors as in acquisition functions
Reviewed By: SebastianAment
Differential Revision: D46519588