Bump croaring version #2407
Merged
Bump croaring version #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
force-pushed
the
bump-croaring
branch
3 times, most recently
from
78639d1 to
1ce1388
Compare
neheb
reviewed
Sep 19, 2025
WillAyd
force-pushed
the
bump-croaring
branch
from
1ce1388 to
55c03c5
Compare
neheb
reviewed
Sep 21, 2025
| 'croaring', | ||
| croaring_sources, | ||
| include_directories: croaring_headers, | ||
| override_options: ['c_std=c11', 'cpp_std=c++11'], |
There was a problem hiding this comment.
hrm I checked this project out.
So the compiled files are C only. The headers are what seem to have C++ support. Which means c++11 is not needed here.
There was a problem hiding this comment.
Alright - I removed the cpp mentions from the project config and override_options
WillAyd
force-pushed
the
bump-croaring
branch
from
55c03c5 to
ce297bd
Compare
WillAyd
force-pushed
the
bump-croaring
branch
from
ce297bd to
22582f0
Compare
|
Hey @neheb just wanted to toss a ping your way in case this got lost in the shuffle. I think all feedback has been addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.