-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Test for the bug with windows.compile_resources #15215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Test for the bug with windows.compile_resources #15215
Conversation
f9cc5f0 to
c15ee9d
Compare
|
This should fix the issue, if either the creator or someone else wants to turn this into a non-draft PR. |
e0da676 to
205a0a7
Compare
|
I did put together something that should work, but I don't have time to finish it. I think it's best to revert 632115e for 1.10 and try again in 1.11 |
34b7582 to
83ccd0f
Compare
|
I'm confused. The initial problem seems to be that current directory is not added to include paths when compiling resources. I tried to add it, and now the "15 resource scripts with duplicate filenames" test is failing with a gcc internal compiler error. But if I don't add the current dir to include path for "windres" resource compiler, my test fail because it doesn't find an included file in the .rc file. The gcc bug has nothing to do with the preprocessor command. It is caused by the added include dir. I think that the added preprocessor command just showed a bug that was already present. |
83ccd0f to
b7cc53b
Compare
b7cc53b to
d0e59a7
Compare
|
Removing from milestone (#15206 is still there) because I don't think this is the right fix. The problem stems from adding project and global arguments for C to the preprocessor invocation, the include path is a red herring. |
|
This might be considered a bug for sure, but it's not the root cause of #15206. And given the windres issue with spaces in file names, it's dangerous to add to the include directories unconditionally. |
Add test for #15206