-
Notifications
You must be signed in to change notification settings - Fork 2.1k
🎌 feat(i18n): Empowering the app with fluent Japanese translations #5324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to ca07dda in 2 minutes and 10 seconds. Click for details.
- Reviewed
122
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
4
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/i18n.ts:40
- Draft comment:
Japanese translation resources have been added. Verify that the key order and namespace mapping (chat, common, settings) match the English version. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to verify the key order and namespace mapping, which violates the rule against asking the author to confirm or verify things. It doesn't provide a specific suggestion or point out a specific issue.
2. web-app/src/locales/jp/chat.json:2
- Draft comment:
Japanese chat translations look natural. Ensure the translations fit the intended context of the app. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to ensure that the translations fit the intended context, which is similar to asking them to double-check or verify something. This violates the rule against asking the author to confirm their intention or ensure behavior.
3. web-app/src/locales/jp/common.json:2
- Draft comment:
Common translation file is consistent with other languages. Double-check formatting and punctuation in the key values. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to double-check formatting and punctuation, which violates the rule against asking the author to double-check things. It doesn't provide a specific suggestion or point out a specific issue.
4. web-app/src/locales/jp/settings.json:2
- Draft comment:
Settings translations follow the established JSON structure. Confirm that technical terms and descriptions are accurately localized. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to confirm the accuracy of translations, which falls under the category of asking for confirmation or verification. It does not provide a specific suggestion or point out a specific issue in the code.
Workflow ID: wflow_UnB0yvnLyfSPTwze
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I saw the pull request "Enhance i18n and add missing i18n for all components #5314." Once that pull request is merged, I can update this one to be compatible. |
Thank you 🙏 |
Hi @YC815 please let us know what we can help to proceed. |
## Describe Your Changes
Added Japanese (
jp
) localization support for the app:✅ Added
jp
entry toLanguageSwitcher.tsx
✅ Integrated
jp
language support ini18n.ts
withcommon
,chat
, andsettings
✅ Created the following Japanese translation files:
jp/common.json
jp/chat.json
jp/settings.json
All translations follow existing English JSON structure and maintain key consistency.
## Fixes Issues
## Self Checklist
i18n.ts
updated properlyLanguageSwitcher
includes new language📝 Note
I am a native speaker of Traditional Chinese and Japanese, so I have submitted two separate i18n pull requests for each language.
All translations were reviewed using both LLM-based proofreading and manual verification to ensure accuracy and naturalness.
Important
Add Japanese localization support with translations for common, chat, and settings, and update language switcher.
jp
) language support ini18n.ts
forcommon
,chat
, andsettings
.jp/common.json
,jp/chat.json
, andjp/settings.json
for translations.jp
entry toLANGUAGES
array inLanguageSwitcher.tsx
to enable language switching.This description was created by
for ca07dda. You can customize this summary. It will automatically update as commits are pushed.