Skip to content

🎌 feat(i18n): Empowering the app with fluent Japanese translations #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

YC815
Copy link

@YC815 YC815 commented Jun 17, 2025

## Describe Your Changes

Added Japanese (jp) localization support for the app:

  • ✅ Added jp entry to LanguageSwitcher.tsx

  • ✅ Integrated jp language support in i18n.ts with common, chat, and settings

  • ✅ Created the following Japanese translation files:

    • jp/common.json
    • jp/chat.json
    • jp/settings.json

All translations follow existing English JSON structure and maintain key consistency.


## Fixes Issues

  • N/A (Initial addition of Japanese translations)

## Self Checklist

  • Japanese translation is contextually appropriate
  • All keys match existing structure
  • No regressions to other languages
  • i18n.ts updated properly
  • LanguageSwitcher includes new language

📝 Note

I am a native speaker of Traditional Chinese and Japanese, so I have submitted two separate i18n pull requests for each language.
All translations were reviewed using both LLM-based proofreading and manual verification to ensure accuracy and naturalness.


Important

Add Japanese localization support with translations for common, chat, and settings, and update language switcher.

  • Localization:
    • Added Japanese (jp) language support in i18n.ts for common, chat, and settings.
    • Created jp/common.json, jp/chat.json, and jp/settings.json for translations.
  • UI Integration:
    • Added jp entry to LANGUAGES array in LanguageSwitcher.tsx to enable language switching.

This description was created by Ellipsis for ca07dda. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to ca07dda in 2 minutes and 10 seconds. Click for details.
  • Reviewed 122 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/i18n.ts:40
  • Draft comment:
    Japanese translation resources have been added. Verify that the key order and namespace mapping (chat, common, settings) match the English version.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify the key order and namespace mapping, which violates the rule against asking the author to confirm or verify things. It doesn't provide a specific suggestion or point out a specific issue.
2. web-app/src/locales/jp/chat.json:2
  • Draft comment:
    Japanese chat translations look natural. Ensure the translations fit the intended context of the app.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to ensure that the translations fit the intended context, which is similar to asking them to double-check or verify something. This violates the rule against asking the author to confirm their intention or ensure behavior.
3. web-app/src/locales/jp/common.json:2
  • Draft comment:
    Common translation file is consistent with other languages. Double-check formatting and punctuation in the key values.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to double-check formatting and punctuation, which violates the rule against asking the author to double-check things. It doesn't provide a specific suggestion or point out a specific issue.
4. web-app/src/locales/jp/settings.json:2
  • Draft comment:
    Settings translations follow the established JSON structure. Confirm that technical terms and descriptions are accurately localized.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to confirm the accuracy of translations, which falls under the category of asking for confirmation or verification. It does not provide a specific suggestion or point out a specific issue in the code.

Workflow ID: wflow_UnB0yvnLyfSPTwze

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Author

@YC815 YC815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@YC815
Copy link
Author

YC815 commented Jun 17, 2025

I saw the pull request "Enhance i18n and add missing i18n for all components #5314." Once that pull request is merged, I can update this one to be compatible.

@samhvw8
Copy link
Contributor

samhvw8 commented Jun 18, 2025

I saw the pull request "Enhance i18n and add missing i18n for all components #5314." Once that pull request is merged, I can update this one to be compatible.

Thank you 🙏

@louis-menlo
Copy link
Contributor

I saw the pull request "Enhance i18n and add missing i18n for all components #5314." Once that pull request is merged, I can update this one to be compatible.

Hi @YC815, just to let you know, the PR is merged. Please help us update. Thanks!!!

@louis-menlo
Copy link
Contributor

Hi @YC815 please let us know what we can help to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants