Skip to content

Conversation

@finaiized
Copy link
Contributor

Below are all the changes. This commit is meant to replace the current tutorial.html file.

  • Fixed some English grammar, random spelling mistakes, and slight touch ups to the language
  • Fixed the many unclosed tags and added alt strings to fix all the validation errors.
    • As HTML5 is not actually used on the page, you can change the doctype to XHTML Strict if you want; it validates as well
  • Tried to beautify the Javascript examples on the page, since they weren't aligned to the edge of the code box (just a nitpick of mine)
  • Consolidated all the pre code blocks. Feel free to move to an external CSS file
  • Small update to reference the most current version of software

Though I've spent a lot of time trying to ensure accuracy, something may have moved somewhere incorrect or I've blundered a typo. That's my disclaimer!

@melonjs
Copy link
Collaborator

melonjs commented Aug 5, 2011

awesome, the first github contribution :)

Thank you for the corrected tutorial, and I'll check that and merge it this weekend when I'm back !

Cheers,
Olivier.

@finaiized
Copy link
Contributor Author

Awesome, my first Github Pull request :)
Anyways, I'll be taking a closer look at it as well later, so maybe if we double-check together, then we can raise it to 2 for no reason at all and quadruple check. I know that doesn't make sense, but oh well.

melonjs pushed a commit that referenced this pull request Aug 6, 2011
Updated/Corrected Tutorial on MelonJS, thanks to finaiized !
@melonjs melonjs merged commit 313ac38 into melonjs:master Aug 6, 2011
juhanapaavola added a commit to juhanapaavola/melonJS that referenced this pull request Jul 16, 2014
Init map sets viewport bounds according to orthogonal map which is not
right for isometric map.
obiot added a commit that referenced this pull request Jul 17, 2014
Viewport bounds not set with isometric map #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants