Skip to content

Add possibility to chose the name of the index #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 27, 2021
Merged

Add possibility to chose the name of the index #283

merged 5 commits into from
Oct 27, 2021

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Oct 19, 2021 •
edited
Loading

@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Oct 20, 2021 •
edited
Loading

@alallema only check for the part in the README with the title #### Custom Index Name the rest is not implemented yet

@bidoubiwa bidoubiwa requested a review from alallema October 20, 2021 13:43
alallema
alallema reviewed Oct 20, 2021
View reviewed changes
Copy link

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made suggestions mainly on the comments but I think it's probably things you'll change as you go along

@bidoubiwa bidoubiwa changed the title Add composite indexes Add possibility to change index name Oct 20, 2021
harish2704 and others added 5 commits October 20, 2021 18:30
@harish2704 @bidoubiwa
Allow specifying custom index name and mapping function for each models
5fa3d87
@harish2704 @bidoubiwa
Document how to customize search indexing
c9ce051 
Fix: include lib directory while packing

fix records count for composite index
handle "update" button for composite index

updating both develooper and end-user documentation

Fix typo in documentation

Start improving README for new features

Fix admin front errors
@bidoubiwa
Replace utils with collection service
8107b10
@bidoubiwa
Add config example in playground
0f24ad9 
Fix linting

Fix method naming

Change naming to explicit collection or indexUid
@bidoubiwa
Change naming to explicit collection or indexUid
1de813d 
Update README.md

Co-authored-by: Amélie <[email protected]>

Update README.md

Co-authored-by: Amélie <[email protected]>

Update services/collection.js

Co-authored-by: Amélie <[email protected]>

Update services/collection.js

Co-authored-by: Amélie <[email protected]>

Update services/collection.js

Co-authored-by: Amélie <[email protected]>

Remove unecessary file in package json
@bidoubiwa bidoubiwa force-pushed the add_composite_indexes branch from 00ee0d7 to 1de813d Compare October 20, 2021 16:31
@bidoubiwa bidoubiwa changed the title Add possibility to change index name WIP: Features update Oct 23, 2021
@bidoubiwa bidoubiwa marked this pull request as draft October 23, 2021 21:04
@bidoubiwa bidoubiwa changed the title WIP: Features update WIP: V0.4.0 Oct 26, 2021
@bidoubiwa bidoubiwa changed the base branch from main to next_v0.4.0_release October 27, 2021 11:22
@bidoubiwa bidoubiwa changed the title WIP: V0.4.0 Add possibility to chose the name of the index Oct 27, 2021
@bidoubiwa bidoubiwa marked this pull request as ready for review October 27, 2021 11:26
@bidoubiwa bidoubiwa merged commit 4df946b into next_v0.4.0_release Oct 27, 2021
@bidoubiwa bidoubiwa deleted the add_composite_indexes branch October 27, 2021 11:26
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

4 participants

@bidoubiwa @alallema @harish2704