-
Notifications
You must be signed in to change notification settings - Fork 64
Feature: allow specifying custom index name and mapping function for each model. #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow specifying custom index name and mapping function for each model. #265
Conversation
handle "update" button for composite index
|
Thanks so much for this PR! I will be reviewing it asap :) 🔥 |
|
@bidoubiwa Any update on this PR? Would love to have this feature as soon as possible. |
|
Hey @harish2704 I will be working on this review and on the repo in itself the following weeks :) Sorry for the delay |
|
@bidoubiwa Any update on this PR? Would love to have this feature as soon as possible. |
|
@vedantpandit22 very sorry, I spend the few last days working on the geo_search since it was introduced in v0.23.0 of MeiliSearch. Strapi is next on my to-do so it should start today or Monday! |
|
Hey @harish2704 I'm testing locally your PR and except for some specifics it is working great. Are you on strapi's discord? If you'r not no problem I can ask my questions directly here. Or you can come on MeiliSearch's slack (accessible in the upper right corner of our documentation) |
|
Hello @harish2704 I'm merging your PR into a new branch on which I'm going to add my modifications since the review I'm making is way to long to start with. Thanks so much for these very cool features! If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form. |
I very happy and exited about this update. Thanks for the update. This information is actually not available from the server , so we may not be able to implement it . Are you aware of this?
I prefer discord over slack. I just joined Strapi's dicord ( username: harish2704 ) and MeiliSearch's slack. You can message me over any channel . ( But will be offline for next 5-6 hours. )
Thank you !. I ll take a look at it. |
Yes this is one of the points that I wanted to raise in the PR. To fix the issue, in case of a composite index I will not If I do not find a way to smartly get the information of which model is enabled or not, I will use the caching system to store the information.
I'll come back to you with some questions if needed :) Thanks again for you amazing work |
Since MeiliSearch doesn't allow multi-index searching, some time, we may need to store multiple entities in single search index.
Also, in most cases, we may not need to index all the fields of a model instance.
This PR address the above two issues by adding
searchIndexNamefield in model definitiontoSearchIndex) which will transform the data before it sent for indexing