Skip to content

Conversation

@vaibhav135
Copy link
Contributor

@vaibhav135 vaibhav135 commented Jul 2, 2023

Pull Request

Related issue

Fixes #434

Took creation reference from #442

What does this PR do?

  • Shows api_key (warning) banner. If the api_key is found in the url.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@bidoubiwa
Copy link
Contributor

Hey @vaibhav135,
Thanks a lot for this PR! I'll wait for my PR to be merged as there are going to be a lot of merge conflicts to handle.

@bidoubiwa
Copy link
Contributor

Hey @vaibhav135 ! Could you resolve the conflicts?

@vaibhav135
Copy link
Contributor Author

Hey @vaibhav135 ! Could you resolve the conflicts?

@bidoubiwa on it.

Signed-off-by: vaibhav bisht <[email protected]>
@vaibhav135
Copy link
Contributor Author

@bidoubiwa done. Please check.

@bidoubiwa
Copy link
Contributor

Hey @vaibhav135 thanks a lot 🙏 The code looks good to me. I'm just checking with @gmourier if we should add the cache on the banner appearance.

@vaibhav135
Copy link
Contributor Author

@bidoubiwa @gmourier any update on this guys?

@bidoubiwa
Copy link
Contributor

I'm merging, if change needed i'll add it :)

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bidoubiwa bidoubiwa added the enhancement New feature or request label Jul 18, 2023
@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 18, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit c3e6a4a into meilisearch:main Jul 18, 2023
@vaibhav135
Copy link
Contributor Author

I'm merging, if change needed i'll add it :)

@bidoubiwa if you need any changes, you can tag me also I will be very happy to do that 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display a warning/message if the api_key url parameter is found

2 participants