-
Notifications
You must be signed in to change notification settings - Fork 62
Added api-key warning banner #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added api-key warning banner #453
Conversation
|
Hey @vaibhav135, |
|
Hey @vaibhav135 ! Could you resolve the conflicts? |
@bidoubiwa on it. |
Signed-off-by: vaibhav bisht <[email protected]>
|
@bidoubiwa done. Please check. |
|
Hey @vaibhav135 thanks a lot 🙏 The code looks good to me. I'm just checking with @gmourier if we should add the cache on the banner appearance. |
|
@bidoubiwa @gmourier any update on this guys? |
|
I'm merging, if change needed i'll add it :) |
bidoubiwa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
|
Build succeeded:
|
@bidoubiwa if you need any changes, you can tag me also I will be very happy to do that 😁 |
Pull Request
Related issue
Fixes #434
Took creation reference from #442
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!