-
Notifications
You must be signed in to change notification settings - Fork 26
Added public initializer for KeyParams. #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bors try |
Hello @mannuch |
tryBuild failed: |
Hi @mannuch thanks for your contribution!! I would like to know if you have any tips to test this behavior, so we can prevent that from happening again in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @mannuch are you still interested in continuing working in this PR? |
Yes I am! Sorry I've been busy the past couple weeks, but I will try to implement the necessary changes at the end of the week. Thanks for your patience! |
4b78ac4
to
46c5143
Compare
46c5143
to
ccc905c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing with Meilisearch ❤️
bors merge!
Thanks again for contributing to Meilisearch ❤️ |
Pull Request
Related issue
The
KeyParams
andKeysQuery
structs do not have publicly accessible initializers. This implies that any code outside theMeiliSearch
module cannot create new instances of these structs.This works in direct contrast to examples laid out in the Meilisearch documentation such as when it displays constructing new
KeyParams
instances to pass to thePOST /keys
endpoint, which can be seen here, if you select Swift as the client language.I've simply explicitly added a public initializers to both the
KeyParams
andKeysQuery
structs.