Skip to content

Conversation

mannuch
Copy link
Contributor

@mannuch mannuch commented Oct 4, 2022

Pull Request

Related issue

The KeyParams and KeysQuery structs do not have publicly accessible initializers. This implies that any code outside the MeiliSearch module cannot create new instances of these structs.

This works in direct contrast to examples laid out in the Meilisearch documentation such as when it displays constructing new KeyParams instances to pass to the POST /keys endpoint, which can be seen here, if you select Swift as the client language.

I've simply explicitly added a public initializers to both the KeyParams and KeysQuery structs.

@bidoubiwa bidoubiwa added the bug Something isn't working label Oct 5, 2022
@curquiza
Copy link
Member

curquiza commented Oct 5, 2022

bors try

@curquiza curquiza linked an issue Oct 5, 2022 that may be closed by this pull request
meili-bors bot added a commit that referenced this pull request Oct 5, 2022
@curquiza
Copy link
Member

curquiza commented Oct 5, 2022

Hello @mannuch
Thanks for the PR!
Looks like there is a linter issue. Could you fix it?

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 5, 2022

try

Build failed:

@brunoocasali
Copy link
Member

Hi @mannuch thanks for your contribution!!

I would like to know if you have any tips to test this behavior, so we can prevent that from happening again in the future.

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mannuch! As @curquiza said, we still have some linting issues. Also, I posted a comment earlier asking about how we can test this :)

@brunoocasali
Copy link
Member

Hi, @mannuch are you still interested in continuing working in this PR?

@mannuch
Copy link
Contributor Author

mannuch commented Oct 18, 2022

Yes I am! Sorry I've been busy the past couple weeks, but I will try to implement the necessary changes at the end of the week.

Thanks for your patience!

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing with Meilisearch ❤️

bors merge!

@meili-bors
Copy link
Contributor

meili-bors bot commented Nov 3, 2022

@meili-bors meili-bors bot merged commit 3d1a58f into meilisearch:main Nov 3, 2022
@brunoocasali
Copy link
Member

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No public initializers for KeyParams and KeysQuery structs.

4 participants