Remove unused code in KeyTests & Add a cleanup step before KeyTests #319
Conversation
| */ | ||
| public struct KeyParams: Codable, Equatable { | ||
| public let description: String | ||
| public var description: String? |
There was a problem hiding this comment.
Just out of curiosity, why are some var and some let? We cant change actions ? Is this because of updateKey ?
| self.client.deleteKey(key: $0.uid) { result in | ||
| switch result { | ||
| case .success: | ||
| () |
There was a problem hiding this comment.
is this the same as keyExpectation.fulfill() ?
There was a problem hiding this comment.
When we define a switch, we should provide an exhaustive list of possibilities, such as success and failure. The problem is that Swift requires me to provide at least a statement when defining a case. Since this method is meant to be a setup and I'm not interested in the success, I could provide the () empty function, but I would like to know if there is another way to handle that.
There was a problem hiding this comment.
Even if you are not interested in the success is .fulfill() not used to stop the wait of the expectation?
There was a problem hiding this comment.
yeah, but that's the point, this code is written inside of the setup(), so it's not meant to be a "test" so in other words, no expectation should be needed 😬
2 participants
descriptionan optional value