Search changes #317
Merged
Search changes #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
reviewed
Aug 3, 2022
|
|
||
| func testSearchFacetsDistributionNullValue() { | ||
| func testSearchFacetDistributionNullValue() { | ||
| let expectation = XCTestExpectation(description: "Search for Books using facets distribution with 0 value") |
There was a problem hiding this comment.
Is the description still relevant?
| func testSearchMatches() { | ||
| let expectation = XCTestExpectation(description: "Search for Books using matches") | ||
|
|
||
| typealias MeiliResult = Result<SearchResult<Book>, Swift.Error> |
There was a problem hiding this comment.
The description above
let expectation = XCTestExpectation(description: "Search for Books using matches")
should become using showMatchesPosition. Sorry I can't make a suggestion on it :(
|
|
||
| func testSearchFacetsDistribution() { | ||
| func testSearchFacetDistribution() { | ||
| let expectation = XCTestExpectation(description: "Search for Books using facets distribution") |
There was a problem hiding this comment.
Suggested change
| let expectation = XCTestExpectation(description: "Search for Books using facets distribution") | |
| let expectation = XCTestExpectation(description: "Search for Books using facets") |
| case .failure(let error): | ||
| dump(error) | ||
| XCTFail("Failed to search with testSearchFacetsDistribution") | ||
| XCTFail("Failed to search with testSearchFacetDistribution") |
There was a problem hiding this comment.
Suggested change
| XCTFail("Failed to search with testSearchFacetDistribution") | |
| XCTFail("Failed to search with testSearchFacetDistributionNullValue") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix breaking changes from 0.28 engine version including:
nbHitsresponse parameter toestimatedTotalHits.exhaustiveNbHitsresponse parameter.exhaustiveFacetsCountresponse parameter.matchesrequest parameter is renamedshowMatchesPosition._matchesInforesponse parameter is renamed_matchesPosition.facetsDistributionrequest parameter is renamedfacets.facetsDistributionresponse parameter is renamedfacetDistribution.