Skip to content

Document changes #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 4, 2022
Merged

Document changes #312

merged 6 commits into from
Aug 4, 2022

Conversation

brunoocasali
Copy link
Member

@brunoocasali brunoocasali commented Aug 2, 2022 •
edited
Loading

  • Remove GetParameters type
  • Add DocumentsQuery type to handle the document endpoints' parameters.
  • Add DocumentsResults type to handle the object response in the GET /documents response.
  • Add a way to choose which fields the Meilisearch engine will return via documents.get
  • Change responses in the create/update/delete actions for documents to return TaskInfo.
  • Create the Queryable protocol to handle the creation of query strings

@brunoocasali brunoocasali requested a review from bidoubiwa August 2, 2022 17:49
bidoubiwa
bidoubiwa suggested changes Aug 3, 2022
View reviewed changes
@bidoubiwa bidoubiwa mentioned this pull request Aug 3, 2022
Merged
@brunoocasali brunoocasali mentioned this pull request Aug 3, 2022
Merged
Base automatically changed from drop-dumps to bump-meilisearch-v0.28.0 August 3, 2022 13:46
@brunoocasali
Copy link
Member Author

@bidoubiwa I made a PR with all the changes you requested #321 (I'll add all the requested changes in this PR)

@brunoocasali brunoocasali requested a review from bidoubiwa August 3, 2022 13:47
bidoubiwa
bidoubiwa approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@brunoocasali brunoocasali merged commit a4af4ea into bump-meilisearch-v0.28.0 Aug 4, 2022
@brunoocasali brunoocasali deleted the document-changes branch August 4, 2022 12:55
@brunoocasali brunoocasali added the enhancement New feature or request label Aug 4, 2022
@brunoocasali brunoocasali mentioned this pull request Aug 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brunoocasali @bidoubiwa