Refactor the request function to use a simple request builder

[ppamorim]

Pull Request

What does this PR do?

Fixes issue pointed on #272

PR checklist

Please check if your PR fulfills the following requirements:

• Does this PR fix an existing issue?
• Have you read the contributing guidelines?
• Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

[bidoubiwa]

I see that only the get method takes the headers as argument.

@ppamorim I saw that you were the one that added the header as argument in the get method. Is this something on purpose or should it be added in the other methods as well?

DOn't worry I can do the PR, I was just wondering if there is a reason for this

  func get(
    api: String,
    param: String? = nil,
    headers: [String: String] = [:],

[ppamorim]

@bidoubiwa I can't approve your suggestions because Github is not accepting my request.

[bidoubiwa]

Hey @ppamorim tell me if it fixed, if it isn't I can commit for you if you'd like to!

[ppamorim]

@bidoubiwa It's not. I could not hear from Github.

[bidoubiwa]

Okey I will make the changes asap!

[bidoubiwa]

Thanks a lot 🔥

[brunoocasali]

Thanks for your PR @ppamorim 💪

Feel free to apply or not the suggestions I made :)

[brunoocasali]

    var request = URLRequest(url: url)
    request.httpMethod = httpMethod.rawValue
    request.setValue(PackageVersion.qualifiedVersion(), forHTTPHeaderField: "User-Agent")
    
    if httpMethod != .get {
      request.httpBody = data
      request.setValue("application/json", forHTTPHeaderField: "Content-Type")
    }
    
    if let apiKey: String = config.apiKey {
      let bearer = "Bearer \(apiKey)"
      request.setValue(bearer, forHTTPHeaderField: "Authorization")
    }
    
    headers.forEach { key, value in
      request.addValue(value, forHTTPHeaderField: key)
    }

    return request

I added some spaces between functions, I think they were important (it is easier to read :D).
But I changed some function execution orders as well, this will help anyone to apply custom data from the headers param when needed (idk, if to fully apply this concept we need to switch over setValue instead of addValue).

[bidoubiwa]

bors try

[brunoocasali]

Perfect, thanks for the contribution! ❤️

[bidoubiwa]

bors merge

[meili-bors]

Build succeeded:

• integration-tests
• linter-check